add server.http for user-defined HTTP endpoints - #6856
Draft
longcw wants to merge 1 commit into
Draft
Conversation
AgentServer.http is a FastAPI app, so agents can serve their own routes
alongside the job worker:
@server.http.get("/token")
async def token() -> dict:
return {"ok": True}
Users get pydantic validation, dependencies, middleware, websockets and
OpenAPI without the framework reimplementing any of it.
The health check and worker info are now ordinary routes on that app,
registered after the user's decorators. A health route of your own keeps
GET /, and agent_health() exposes the checks it would have run. GET
/worker stays reserved, since the control plane and the lk CLI read it.
uvicorn replaces the aiohttp runner. It captures SIGINT and SIGTERM
unconditionally, so capture_signals is overridden to leave them to the
CLI, and its own loggers are quieted because the startup banner
duplicates ours. The bound port is read back from the IPv4 socket, since
an empty host binds one socket per address family, each with its own
port when the port is 0.
websockets is a new dependency: uvicorn refuses websocket upgrades
without an implementation installed, and it only reached the tree
through optional plugins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.