fix(voice): preserve tool responses on early exits - #2260
Open
swayamg20 wants to merge 2 commits into
Open
Conversation
Return an error output for calls rejected by toolChoice none and flush completed realtime tool outputs before interrupted generations exit.
🦋 Changeset detectedLatest commit: d7be9c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolChoiceis set tonone, without executing the toolFixes #2249
Validation
pnpm exec vitest run agents/src/voice/generation_tools.test.ts agents/src/voice/realtime_tool_output_commit.test.ts agents/src/voice/agent_activity.test.ts— 59 passedpnpm exec vitest run agents/src— 115 files passed; 1,590 tests passed, 5 skippedpnpm --filter @livekit/agents typecheckpnpm --filter @livekit/agents buildpnpm -w lint:fix— all 40 packages passed with 145 existing warningspnpm -w format:checkgit diff --check