fix(requester): keep non-stream timeout active after headers - #191
Open
lonr-6 wants to merge 2 commits into
Open
fix(requester): keep non-stream timeout active after headers#191lonr-6 wants to merge 2 commits into
lonr-6 wants to merge 2 commits into
Conversation
lonr-6
marked this pull request as ready for review
August 18, 2026 09:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
FingerprintRequester.request()unconditionally clearedtimeoutIdas soon as it parsed\r\n\r\n. That is appropriate for long-lived streaming responses, but it also disabled the only JavaScript-side watchdog for normal requests. If the fingerprint child or upstream sent headers and then stopped producing a body without exiting, the Promise could remain pending indefinitely.The timeout is now cleared after headers only when
onDownloadProgressidentifies the streaming path. Non-stream requests retain the watchdog until the child exits.Verification
ECONNABORTEDinstead of hangingmain(849deac8)Refs #159
Refs #175