Skip to content

ci: add Makefile for dev setup with prek hooks#1417

Merged
liudger merged 2 commits intomainfrom
add-makefile
Mar 25, 2026
Merged

ci: add Makefile for dev setup with prek hooks#1417
liudger merged 2 commits intomainfrom
add-makefile

Conversation

@liudger
Copy link
Owner

@liudger liudger commented Mar 25, 2026

Add a Makefile with common development commands:

  • make setup — Install dev dependencies and prek git hooks
  • make lint — Run all pre-commit hooks via prek
  • make test — Run tests
  • make coverage — Run tests with coverage report

This ensures prek hooks are automatically installed when setting up the dev environment, preventing lint errors from being pushed without local checks.

Copilot AI review requested due to automatic review settings March 25, 2026 10:56
@liudger liudger added maintenance Generic maintenance tasks. labels Mar 25, 2026
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (dcc3e13) to head (c59b7ec).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1417   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files           6        6           
  Lines         986      986           
  Branches      139      139           
=======================================
  Hits          985      985           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a developer Makefile, but it also changes the library’s heating-circuit support and parameter mappings (not reflected in the PR title/description).

Changes:

  • Add a Makefile with setup, lint, test, and coverage targets using uv + prek.
  • Reduce supported heating circuits from 3 to 2 (remove HC3 sections/params and related tests).
  • Update heating circuit 2 parameter IDs (and adjust fixtures/tests accordingly).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Makefile Adds common dev commands (setup/lint/test/coverage).
src/bsblan/constants.py Drops HC3 support; updates HC2 parameter IDs and related mappings.
src/bsblan/bsblan.py Updates section typing and docs to align with 2-circuit support.
tests/test_circuit.py Removes HC3 tests and updates invalid-circuit assertions.
tests/test_constants.py Updates required API config sections to exclude HC3.
tests/test_initialization.py Updates API section mocks to exclude HC3.
tests/test_api_validation.py Updates API validation cache test data to exclude HC3.
tests/test_hotwater_state.py Updates API v3 test structure to exclude HC3.
tests/fixtures/state_circuit2.json Updates fixture parameter IDs for circuit 2.

@liudger liudger added the ci Work that improves the continue integration. label Mar 25, 2026
@sonarqubecloud
Copy link

@liudger liudger merged commit 5eec464 into main Mar 25, 2026
15 checks passed
@liudger liudger deleted the add-makefile branch March 25, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Work that improves the continue integration. maintenance Generic maintenance tasks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants