Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Core/Meeting.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class Meeting

private readonly string $creationDate;

private readonly int $voiceBridge;
private readonly string $voiceBridge;

private readonly string $dialNumber;

Expand Down Expand Up @@ -86,7 +86,7 @@ public function __construct(protected \SimpleXMLElement $rawXml)
$this->meetingName = $this->rawXml->meetingName->__toString();
$this->creationTime = (float) $this->rawXml->createTime;
$this->creationDate = $this->rawXml->createDate->__toString();
$this->voiceBridge = (int) $this->rawXml->voiceBridge;
$this->voiceBridge = $this->rawXml->voiceBridge->__toString();
$this->dialNumber = $this->rawXml->dialNumber->__toString();
$this->hasBeenForciblyEnded = $this->rawXml->hasBeenForciblyEnded->__toString() === 'true';
$this->isRunning = $this->rawXml->running->__toString() === 'true';
Expand Down Expand Up @@ -126,7 +126,7 @@ public function getCreationDate(): string
return $this->creationDate;
}

public function getVoiceBridge(): int
public function getVoiceBridge(): string
{
return $this->voiceBridge;
}
Expand Down
6 changes: 3 additions & 3 deletions src/Parameters/CreateMeetingParameters.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@
* @method $this setWelcome(string $welcome)
* @method string getDialNumber()
* @method $this setDialNumber(string $dialNumber)
* @method int getVoiceBridge()
* @method $this setVoiceBridge(int $voiceBridge)
* @method string getVoiceBridge()
* @method $this setVoiceBridge(string $voiceBridge)
* @method string getWebVoice()
* @method $this setWebVoice(string $webVoice)
* @method int getMaxParticipants()
Expand Down Expand Up @@ -167,7 +167,7 @@ class CreateMeetingParameters extends MetaParameters
{
protected ?string $welcome = null;
protected ?string $dialNumber = null;
protected ?int $voiceBridge = null;
protected ?string $voiceBridge = null;
protected ?string $webVoice = null;
protected ?int $maxParticipants = null;
protected ?string $loginURL = null;
Expand Down
4 changes: 2 additions & 2 deletions src/Responses/CreateMeetingResponse.php
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ public function getCreationTime(bool $milliseconds = true)
return $milliseconds ? (float) $this->rawXml->createTime : (int) ($this->rawXml->createTime / 1000);
}

public function getVoiceBridge(): int
public function getVoiceBridge(): string
{
return (int) $this->rawXml->voiceBridge;
return $this->rawXml->voiceBridge->__toString();
}

public function getDialNumber(): string
Expand Down
2 changes: 1 addition & 1 deletion tests/common/TestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ protected function generateCreateParams(): array
'meetingID' => $this->faker->uuid,
'autoStartRecording' => $this->faker->boolean(50),
'dialNumber' => $this->faker->phoneNumber,
'voiceBridge' => $this->faker->randomNumber(5, true),
'voiceBridge' => $this->faker->numerify('#####'),
'webVoice' => $this->faker->word,
'logoutURL' => $this->faker->url,
'maxParticipants' => $this->faker->numberBetween(2, 100),
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/create_meeting.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<attendeePW>tK6J5cJv3hMLNx5IBePa</attendeePW>
<moderatorPW>34Heu0uiZYqCZXX9C4m2</moderatorPW>
<createTime>1453283819419</createTime>
<voiceBridge>76286</voiceBridge>
<voiceBridge>06286</voiceBridge>
<dialNumber>613-555-1234</dialNumber>
<createDate>Wed Jan 20 04:56:59 EST 2016</createDate>
<hasUserJoined>false</hasUserJoined>
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/BigBlueButtonTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ public function testGetMeetings(): void
<internalMeetingID>12345</internalMeetingID>
<createTime>1531241258036</createTime>
<createDate>Tue Jul 10 16:47:38 UTC 2018</createDate>
<voiceBridge>70066</voiceBridge>
<voiceBridge>07066</voiceBridge>
<dialNumber>613-555-1234</dialNumber>
<attendeePW>ap</attendeePW>
<moderatorPW>mp</moderatorPW>
Expand Down Expand Up @@ -441,7 +441,7 @@ public function testGetMeetings(): void
$this->assertEquals('12345', $response->getMeetings()[0]->getInternalMeetingId());
$this->assertEquals(1531241258036, $response->getMeetings()[0]->getCreationTime());
$this->assertEquals('Tue Jul 10 16:47:38 UTC 2018', $response->getMeetings()[0]->getCreationDate());
$this->assertEquals(70066, $response->getMeetings()[0]->getVoiceBridge());
$this->assertEquals('07066', $response->getMeetings()[0]->getVoiceBridge());
$this->assertEquals('613-555-1234', $response->getMeetings()[0]->getDialNumber());
$this->assertFalse($response->getMeetings()[0]->isRunning());
$this->assertEquals(0, $response->getMeetings()[0]->getDuration());
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/Responses/CreateMeetingResponseTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public function testCreateMeetingResponseContent(): void
$this->assertEquals('1a6938c707cdf5d052958672d66c219c30690c47-1524212045514', $this->meeting->getInternalMeetingId());
$this->assertEquals('bbb-none', $this->meeting->getParentMeetingId());
$this->assertEquals(1453283819419, $this->meeting->getCreationTime());
$this->assertEquals(76286, $this->meeting->getVoiceBridge());
$this->assertEquals('06286', $this->meeting->getVoiceBridge());
$this->assertEquals('Wed Jan 20 04:56:59 EST 2016', $this->meeting->getCreationDate());
$this->assertEquals('613-555-1234', $this->meeting->getDialNumber());
$this->assertFalse($this->meeting->hasUserJoined());
Expand All @@ -65,10 +65,10 @@ public function testCreateMeetingResponseTypes(): void
{
$this->assertEachGetterValueIsString($this->meeting, [
'getReturnCode', 'getInternalMeetingId', 'getParentMeetingId',
'getDialNumber', 'getCreationDate',
'getDialNumber', 'getVoiceBridge', 'getCreationDate',
]);
$this->assertEachGetterValueIsDouble($this->meeting, ['getCreationTime']);
$this->assertEachGetterValueIsInteger($this->meeting, ['getDuration', 'getVoiceBridge']);
$this->assertEachGetterValueIsInteger($this->meeting, ['getDuration']);
$this->assertEachGetterValueIsBoolean($this->meeting, ['hasUserJoined', 'hasBeenForciblyEnded']);
}

Expand Down
4 changes: 2 additions & 2 deletions tests/unit/Responses/GetMeetingInfoResponseTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,11 @@ public function testGetMeetingInfoResponseTypes(): void

$this->assertEachGetterValueIsString($info, [
'getMeetingName', 'getMeetingId', 'getInternalMeetingId',
'getCreationDate', 'getDialNumber',
'getCreationDate', 'getDialNumber', 'getVoiceBridge',
]);

$this->assertEachGetterValueIsInteger($info, [
'getVoiceBridge', 'getDuration', 'getParticipantCount',
'getDuration', 'getParticipantCount',
'getListenerCount', 'getVoiceParticipantCount', 'getVideoCount', 'getMaxUsers', 'getModeratorCount',
]);

Expand Down
4 changes: 2 additions & 2 deletions tests/unit/Responses/GetMeetingsResponseTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ public function testGetMeetingsResponseTypes(): void

$aMeeting = $this->meetings->getMeetings()[2];

$this->assertEachGetterValueIsString($aMeeting, ['getMeetingId', 'getMeetingName', 'getCreationDate', 'getDialNumber']);
$this->assertEachGetterValueIsString($aMeeting, ['getMeetingId', 'getMeetingName', 'getCreationDate', 'getDialNumber', 'getVoiceBridge']);
$this->assertEachGetterValueIsDouble($aMeeting, ['getCreationTime']);
$this->assertEachGetterValueIsInteger($aMeeting, [
'getVoiceBridge', 'getParticipantCount', 'getListenerCount',
'getParticipantCount', 'getListenerCount',
'getVoiceParticipantCount', 'getVideoCount', 'getDuration',
]);
$this->assertEachGetterValueIsBoolean($aMeeting, ['hasBeenForciblyEnded', 'isRunning', 'hasUserJoined']);
Expand Down
Loading