Repository navigation
Conversation
rcosta358
changed the title
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Reviewed with Claude Code (reviewer + adversarial agents per PR, findings checked against the code before posting).
|
|
||
| - name: Test server | ||
| working-directory: server | ||
| run: mvn -B test |
There was a problem hiding this comment.
The server tests run twice per CI run. This step runs mvn -B test, and the "Build server" step below runs mvn -B package, which goes through the test phase again. Either drop this step and let package run them, or add -DskipTests to the package step.
There was a problem hiding this comment.
Removed the separate mvn test step; mvn package now runs the server tests once and builds the JAR. Validated the workflow YAML and installed the extension successfully.
Co-authored-by: Codex <noreply@openai.com>
# Conflicts: # .github/workflows/test.yml Co-authored-by: Codex <noreply@openai.com>
|
Restacked this PR on #142 to put the release, client tests, server tests, and integration API into one dependency chain before #147. The diff against the new base preserves this PR's feature changes. Combined validation passed 32 client tests, 24 server tests, lint, production/test type checks, and extension installation; this PR's new Checks run also passed. |
Expose readiness, diagnostic events (including empty results), current status/diagnostics, and webview messages through the running extension’s activation API. Startup failures reject readiness while existing extension behavior stays intact. Validation: lint, TypeScript, production bundle, VSIX packaging, and extension installation passed. The integration smoke test in #131 uses this API. Depends on #141. Closes #130. Generated by Codex. --------- Co-authored-by: Codex <codex@openai.com> Co-authored-by: Codex <noreply@openai.com>
## Description Closes #134. Add weekly and manual Windows/macOS runs for client and server unit tests plus VS Code stable integration tests, with logs uploaded on failure. The diff contains only `platform-tests.yml`. ## Related Issues Depends on #146. The existing prerequisite PRs now form one chain through #145, #144, #143, #141, #142, #140, #139, #138, and #137 to main. The schedule becomes active when merged to the default branch. Validation: 32 client tests, 24 server tests, lint, production/test TypeScript checks, and extension installation passed. Stable and minimum VS Code integration passed in [PR CI](https://github.com/liquid-java/vscode-liquidjava/actions/runs/37541530280). Fresh [Windows/macOS validation](https://github.com/liquid-java/vscode-liquidjava/actions/runs/37541530341) passed on the final commit, including both unit-test suites and VS Code integration. 🤖 Generated with [Codex](https://openai.com/codex/) --------- Co-authored-by: Codex <noreply@openai.com>
2 participants
Adds 24 JUnit tests for source-folder selection, Windows-style file URIs, source positions, diagnostic DTOs, and context conversion. Runs server tests in CI.
Validated with Java 21: Maven tests/package, client lint, TypeScript checks, and extension installation.
Closes #129. Depends on #142 for the combined client/server test workflow.
Generated by Codex.