Repository navigation
Fix lint tooling and move publishing to Node 22 - #137
Conversation
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
One small thing for #124's Node 22 move, outside this diff:
.devcontainer/devcontainer.json still uses mcr.microsoft.com/devcontainers/javascript-node:20. The point of the move is that the Vitest and @vscode/test-electron versions added later in this stack need Node 22, so anyone working in the devcontainer will hit that once #140 / #144 land, while CI on 22 passes. Suggest bumping the image to javascript-node:22, and optionally adding "engines": { "node": ">=22" } to client/package.json.
Reviewed with Claude Code (reviewer + adversarial agents per PR, findings checked against the code before posting).
Co-authored-by: Codex <noreply@openai.com>
|
Updated the devcontainer to Node 22 and added Node >=22 to the client manifest and lockfile in 6120840. Lint and extension packaging/install passed. |
Closes #125. Depends on #137. Run lint, TypeScript, the server build, and packaged runtime checks on every pull request and on pushes to main. Keep reusable checks for publishing, and execute the required Checks job without a skip condition. Validated workflow trigger coverage, Java 20 API targeting under JDK 21, packaging, and extension installation. 🤖 Generated with [Codex](https://openai.com/codex/) --------- Co-authored-by: Codex <noreply@openai.com>
## Description Closes #134. Add weekly and manual Windows/macOS runs for client and server unit tests plus VS Code stable integration tests, with logs uploaded on failure. The diff contains only `platform-tests.yml`. ## Related Issues Depends on #146. The existing prerequisite PRs now form one chain through #145, #144, #143, #141, #142, #140, #139, #138, and #137 to main. The schedule becomes active when merged to the default branch. Validation: 32 client tests, 24 server tests, lint, production/test TypeScript checks, and extension installation passed. Stable and minimum VS Code integration passed in [PR CI](https://github.com/liquid-java/vscode-liquidjava/actions/runs/37541530280). Fresh [Windows/macOS validation](https://github.com/liquid-java/vscode-liquidjava/actions/runs/37541530341) passed on the final commit, including both unit-test suites and VS Code integration. 🤖 Generated with [Codex](https://openai.com/codex/) --------- Co-authored-by: Codex <noreply@openai.com>
2 participants
Closes #124.
Update ESLint, remove obsolete test scripts and unused tooling, and move publishing to Node 22. Fix existing semicolon violations.
Validated on Node 22: dependency install, lint, type checking, production build, and extension installation.
Generated by Codex.