feat: add SOCKET_PROXY_PORT environment variable#46
Closed
upmcplanetracker wants to merge 1 commit into
Closed
Conversation
Added new env SOCKET_PROXY_PORT that defaults to 2375 but is user changeable
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Member
|
You're really supposed to put this container in a user defined bridge network along with the other container that needs access, isolated from anything else. The connection should go through that isolated network only. |
Author
|
Thank you for reviewing it. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new env SOCKET_PROXY_PORT that defaults to 2375 but is user changeable in rootless podman environments with
Network=hostas well as other cases.Description:
This PR adds an optional
SOCKET_PROXY_PORTenvironment variable to thedocker-entrypoint.shscript. It allows users to override the default port (2375). If the variable is not set, it defaults to2375to ensure full backward compatibility.Benefits of this PR and context:
This change is primarily to support
network=hostdeployment configurations. When running in host networking mode, standardDocker -porPublishPortmappings are ignored. Users are currently forced to use the hardcoded2375port, which leads to conflicts if other services on the host are already using it. This change provides the flexibility needed for hardened or complex production environments. This also addresses the request originally opened in issue #44.How Has This Been Tested?
I tested this by pulling the image and manually overriding the docker-entrypoint.sh logic on a local NUC. I verified that:
Source / References:
Requested in issue: #44