fix(svc-de): depend on legacy-cont-init so runtime env writes complete before the desktop starts - #184
Open
junkerderprovinz wants to merge 1 commit into
Conversation
…e before the desktop starts (linuxserver#178) Signed-off-by: junkerderprovinz <jdp@braethoria.com>
Contributor
Author
|
Friendly nudge on this one whenever you get a chance, it's green and conflict-free against |
Member
|
I'll get this in on a next waterfall, do not have one planned yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178.
svc-de/runstarts with#!/usr/bin/with-contenv bash, so it snapshots the container environment when it starts. Variables a downstreamcont-init.dscript writes at runtime into/run/s6/container_environment/are produced by the legacy cont-init compatibility oneshot, which is not a declared dependency ofsvc-de(s6-rc-db all-dependencies svc-dedoes not list it). On slow storage the desktop can win the race and start openbox, and whatever it launches, before those variables exist.This adds a dependency edge from
svc-detolegacy-cont-init, so the desktop only starts after the legacycont-init.dscripts and their env writes have completed. It is an additive ordering edge with no behaviour change on fast storage.