WIP: nemo-icon-container: steal icon list before destruction to prevent re…#3775
Open
leigh123linux wants to merge 1 commit into
Open
WIP: nemo-icon-container: steal icon list before destruction to prevent re…#3775leigh123linux wants to merge 1 commit into
leigh123linux wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts nemo_icon_container_clear() to detach the icon list before destroying icon items, aiming to avoid re-entrant crashes during icon destruction.
Changes:
- Stores the current icon list in a local variable before clearing
details->icons. - Frees
details->new_iconsbefore destroying the stolen icon list. - Destroys icons from the saved list and then frees that list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leigh123linux
force-pushed
the
nemo-icon-container-crash
branch
from
6553156 to
26208e1
Compare
leigh123linux
force-pushed
the
nemo-icon-container-crash
branch
from
26208e1 to
e3eeff9
Compare
Comment on lines
+5272
to
+5273
| g_hash_table_destroy (details->icon_set); | ||
| details->icon_set = g_hash_table_new (g_direct_hash, g_direct_equal); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-entrant crash