Repository navigation
verify.py: make verification non-blocking and fix mirror/HWE URLs (#148) - #156
Closed
ronitgupta138 wants to merge 2 commits into
Closed
ronitgupta138 wants to merge 2 commits into
ronitgupta138 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Three unresolved critical concurrency and callback issues block safe approval.
Review effort: Lite
Findings: 3
Open (3)
What changed in this PR
This PR makes ISO verification asynchronous and updates Linux Mint mirror, HWE, and HKPS keyserver handling.
Changes:
- Runs URL and file verification asynchronously.
- Marshals GTK updates and dialogs to the main loop.
- Updates mirror URLs and adds HWE ISO detection.
- Prioritizes encrypted keyservers.
| File | Summary |
|---|---|
lib/verify.py |
Adds asynchronous verification and URL updates. Three critical issues remain: keyword arguments break idle_function, GTK controls are accessed off the main thread, and concurrent verification can race on shared files and the GPG keyring. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| self.show_result("dialog-error", _("Checksum mismatch"), | ||
| summary=_("Download the ISO image again. Its checksum does not match.")) | ||
|
|
||
| @async_function |
| self.show_result("dialog-error", _("Checksum mismatch"), | ||
| summary=_("Download the ISO image again. Its checksum does not match.")) | ||
|
|
||
| @async_function |
| return (False, _("The SHA256 sum of the ISO image is incorrect.")) | ||
| return (False, _("The SHA256 sums file does not contain sums for this ISO image.")) | ||
|
|
||
| @idle_function |
…gs in idle_function, and marshal GTK widget access to main thread
Author
|
Updated to resolve all 3 concurrency and callback issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #148
Summary of Changes:
verify_urlandverify_fileswith@async_functionand UI updates (show_result,dialog) with@idle_functionso GPG keyserver lookups and checksum verification run asynchronously without locking the GTK main loop.MINT_MIRRORtohttps://mirrors.edge.kernel.org/linuxmintto avoid 301 redirection delays.-hweISOs inguess_urlsto queryhttps://mirrors.edge.kernel.org/linuxmint/hwe/sha256sum.txt.hkps://keyserver.ubuntu.com,hkps://keys.openpgp.org) over plaintext port 11371 to avoid firewall blocking.