Fixes in "printers@cinnamon.org"

[hans-fritz-pommes]

I encountered several small issues with the printers applet.
I modified the applet.js in /usr/share/cinnamon/applets/printers@cinnamon.org and tested printing documents.
The things I did correct:

• The "Cancel all jobs" command didn't work for an user who had no permisisons to run cancel -a for a specific printer, even if all of the jobs on this printer belonged to him.
  -> Now the "Cancel all jobs" command tries to cancel every single job, not cancel -a for every printer
• The appearance of the listed jobs was really bad: e.g. when you had more than one job, the description for every job was "<desc. first job><desc. second job><desc..." and so on.
• The job description consisted of: (job number) lpstat -o (lpstat several times, if there was more than one job - see point before)
  -> The description is now: (job number) 'document_name' on <printer_name> (<size in Bytes/MB/KB>) by <user> (using lpq -a).

The following problem could occur:
If a job has the same number as byte-size like the job-id of the following one, the username and the filesize of the first one will be strange (job-id and functions stay working).
I would say this will happen that seldom - we should ignore it.
Which user will open the menu exactly in that minute and have a problem with a strange username or filesize?

EDIT: fixed in new commit

[hans-fritz-pommes]

Oh and I changed icons. If you think they're ugly, just revert it

[hans-fritz-pommes]

I have an idea how to fix this mini-problem (identical bytes & job-number). But later

[hans-fritz-pommes]

Ok, now the identical bytes/document-name & job-number-problem is fixed.

[hans-fritz-pommes]

Sorry that I'm so chaotic
I forgot to take care of document names with whitespaces

[github-actions]

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

---

Found 1 potential issue(s):

⚠️ lang_bind

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:218

Util.spawn_async(['/usr/bin/lpq', '-a'], Lang.bind(this, function(out2) {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.

---

Automated pattern check.

[github-actions]

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Having code flagged
by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

---

Found 1 potential issue(s):

⚠️ lang_bind

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:203

Util.spawn_async(['/usr/bin/lpq', '-a'], Lang.bind(this, function(out2) {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.

---

Automated pattern check.

[hans-fritz-pommes]

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or maintainability issues, or that may already be provided by Cinnamon. Having code flagged by it doesn't automatically disqualify a pull request.

This check is not perfect will not replace a normal review.

Found 1 potential issue(s):

⚠️ lang_bind

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js:218

Util.spawn_async(['/usr/bin/lpq', '-a'], Lang.bind(this, function(out2) {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.

Automated pattern check.

What should be done with that?

[leigh123linux]

Please squash the commits into one.

[mtwebster]

What should be done with that?

What it suggests - use an arrow function instead of using Lang.bind(). Look at other applets, it's a pretty straightforward change.

[hans-fritz-pommes]

By the way:
I was wondering why ever lpstat was used for gathering the job-data.
This pull request removed lpq. I thought every system having lpstat also has lpq since it's a part of cups?

[hans-fritz-pommes]

Those new commits intend to make it compatible with a turned-off CUPS-service

[hans-fritz-pommes]

Please squash the commits into one.

I will do that when merging

[hans-fritz-pommes]

Now the guy from #13039 shouldn't have problems anymore with missing lpq and there shouldn't be a problem with missing / not running cups (#9265).

[mtwebster]

This might not do what you expect:

The callback will evaluate sendJobs[sendJobs.length - 1] at the time of activation, not when you created the callback. You should probably just do something less clever like:

let sendjob = new PopupMenu.PopupIconMenuuItem.....
sendJobs.push(sendjob)
...
...

then reference sendJob as the callback argument.

[mtwebster]

Can we drop the python script? util.spawnCommandLineAsyncIO() should work fine in this case - they're all fixed arguments. Sorry I should have caught this earlier...

[mtwebster]

format_size_for_display() is deprecated - use format_size() instead (same arguments).