[WIP] Add early exit to xlet-settings if no instances exist, handle adding/removing xlets while xlet-settings is open.

[samw-26]

xlet-settings now exits if command is run when no instances of an xlet exist.

Added logic to handle adding and removing xlet while xlet-settings is open.

• Arrows will be hidden if number of instances is less than 2
• Arrows will be shown if number of instances is greater than 1
• Next instance will be selected if currently selected xlet is removed
• xlet-settings will exit if last instance of xlet is removed
• Corresponding setting pages are created/removed when xlets are created/removed

[Copilot]

Pull Request Overview

This PR adds functionality to handle dynamic xlet instance changes while the xlet-settings window is open. The main improvements include early exit validation when no instances exist, and real-time UI updates when instances are added or removed.

• Early exit validation when no xlet instances are found
• Dynamic monitoring and handling of xlet instance additions/removals
• Automatic UI updates for navigation buttons based on instance count

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 7 comments.

File	Description
xlet-settings.py	Implements instance monitoring, dynamic settings page creation/removal, navigation refactoring, and early exit logic
JsonSettingsWidgets.py	Adds file not found handling to prevent crashes when config files are removed

Comments suppressed due to low confidence (1)

files/usr/share/cinnamon/cinnamon-settings/xlet-settings.py:500

• Except block directly handles BaseException.

        except:

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mtwebster]

Please rebase and have a look at two areas noted.

[mtwebster]

I'm having trouble with keybinding widgets I think due to 95e9d25.

All keybinding widgets derive their values from the KeybindingTable now, not directly from the json files when xlet-settings is loading.

I don't think it's serious, but a race condition when adding or removing an xlet that contains a keybinding setting. Please have a look. (I was testing with the menu applet but anything with a keybinding probably works).

Adding an instance, I believe xlet-settings is adding the new instance before the KeybindingTable has discovered the new instance and registered the keybinding there:

Traceback (most recent call last):
  File "/usr/share/cinnamon/cinnamon-settings/xlet-settings.py", line 579, in on_config_file_added
    self.create_new_settings_page(file.get_path())
  File "/usr/share/cinnamon/cinnamon-settings/xlet-settings.py", line 583, in create_new_settings_page
    self.create_settings_page(path)
  File "/usr/share/cinnamon/cinnamon-settings/xlet-settings.py", line 346, in create_settings_page
    self.build_with_layout(settings_map, info, instance_box, first_key)
  File "/usr/share/cinnamon/cinnamon-settings/xlet-settings.py", line 407, in build_with_layout
    widget = globals()[XLET_SETTINGS_WIDGETS[settings_type]](key, info["settings"], item)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/cinnamon/cinnamon-settings/bin/JsonSettingsWidgets.py", line 341, in __init__
    super(NewClass, self).__init__(**kwargs)
  File "/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py", line 484, in __init__
    self.keybinding.connect("changed", self.on_kb_table_entry_changed)
    ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'connect'

Removing an instance (via the applet context menu) - Somehow the KeybindingTable still thinks the json file exists:

Traceback (most recent call last):
  File "/usr/share/cinnamon/cinnamon-settings/bin/KeybindingTable.py", line 358, in load_json_settings
    self.entries = self.getConfigSettings()
                   ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/cinnamon/cinnamon-settings/bin/KeybindingTable.py", line 363, in getConfigSettings
    with open(self.schema, encoding="utf-8") as config_file:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/home/mtwebster/.config/cinnamon/spices/menu@cinnamon.org/75.json'

[samw-26]

I changed the instance_id property to be the same as config id. I was not sure why there was a distinction before, let me know if this is okay?

[samw-26]

Updated keybinding table and keybinding class to handle adding and removing xlets. Xlet settings will now listen to the keybind table spice change event before creating a new settings page.