Skip to content

fix: use bunyan stdSerializers for error fields #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skwowet merged 2 commits into from
Aug 20, 2026
+4 −31
Merged

fix: use bunyan stdSerializers for error fields #4496

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bee905
fix: use bunyan stdSerializers for error fields (CM-1280)
skwowet Aug 20, 2026
a4c6a99
Merge branch 'main' into fix/cm-1280-bunyan-std-error-serializer
skwowet Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 4 additions & 31 deletions services/libs/logging/src/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,36 +5,6 @@ import { IS_DEV_ENV, IS_TEST_ENV, LOG_LEVEL, SERVICE } from '@crowd/common'

import { Logger } from './types'

type SerializableError = {
toJSON?: () => unknown
}

function serializeError(err: unknown) {
if (err && typeof err === 'object') {
const toJSON = (err as SerializableError).toJSON

if (typeof toJSON === 'function') {
try {
const serialized = toJSON.call(err)

if (serialized !== undefined) {
return serialized
}
} catch {
// Fall back to Bunyan's standard error serialization.
}
}
}

return Bunyan.stdSerializers.err(err)
}

const serializers = {
...Bunyan.stdSerializers,
err: serializeError,
error: serializeError,
}

const PRETTY_FORMAT = new BunyanFormat({
outputMode: 'short',
levelInString: true,
Expand All @@ -58,7 +28,10 @@ export function getServiceLogger(): Logger {
name: SERVICE,
level: LOG_LEVEL as Bunyan.LogLevel,
stream: usePrettyLogs ? PRETTY_FORMAT : JSON_FORMAT,
serializers,
serializers: {
...Bunyan.stdSerializers,
error: Bunyan.stdSerializers.err,
},
}

serviceLoggerInstance = Bunyan.createLogger(options)
Expand Down
Loading