fix: preserve legacy DConfig cache with prefixed cache

[18202781743]

Summary

• cherry-pick eagle Authorized permission parsing with original metadata
• load legacy DConfig cache before the prefixed cache
• let prefixed values override legacy values and save merged legacy-only keys to the new path
• add user/global/no-appid/subpath coverage

Validation

• DTK5 Release full build: passed (-j6)
• DTK6 Release full build: passed (-j6)
• focused DConfigFile tests: 5/5 passed on DTK5 and DTK6

No migration state file or claimed-key tracking is introduced.

Summary by Sourcery

Preserve backward compatibility for legacy DConfig caches while adding authorized permission parsing and comprehensive prefixed-cache coverage.

New Features:

• Support authorized read-only and authorized read-write permission metadata values.

Bug Fixes:

• Preserve legacy DConfig cache values when a prefixed cache is used, while allowing prefixed values to take precedence.

Enhancements:

• Merge legacy-only cache entries into prefixed caches through the existing save flow across user, global, no-appid, and subpath configurations.

Documentation:

• Document that prefixed caches load legacy data first, overlay prefixed values, and save to the prefixed path.

Tests:

• Add coverage for authorized permissions and prefixed-cache overlay behavior across user, global, no-appid, and subpath scenarios.

Chores:

• Update copyright years and package metadata.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's Guide

The PR preserves backward compatibility when a cache-path prefix is introduced by loading the legacy cache first, overlaying prefixed values, and using the existing dirty/save flow to migrate legacy-only keys; it also adds authorized permission parsing and broad regression coverage for user, global, no-appid, and subpath configurations.

Sequence diagram for prefixed DConfig cache migration

sequenceDiagram
    participant Caller
    participant DConfigCacheImpl
    participant LegacyCache
    participant PrefixedCache
    participant SavePath

    Caller->>DConfigCacheImpl: load(localPrefix)
    DConfigCacheImpl->>LegacyCache: loadCache(legacyCacheDir, legacyKeys)
    DConfigCacheImpl->>PrefixedCache: loadCache(newCacheDir, newKeys)
    PrefixedCache-->>DConfigCacheImpl: overlay prefixed values
    DConfigCacheImpl->>DConfigCacheImpl: mark cacheChanged for legacy-only keys
    Caller->>DConfigCacheImpl: save(localPrefix)
    DConfigCacheImpl->>SavePath: save merged values under prefixed cache path

Loading

Flow diagram for legacy and prefixed cache resolution

flowchart TD
    A[load cache] --> B{cache prefix set?}
    B -->|No| C[load prefixed path]
    B -->|Yes| D[load legacy path first]
    D --> E{legacy cache valid?}
    E -->|Invalid| F[continue with prefixed cache]
    E -->|Loaded| G[retain legacy values]
    F --> H[load prefixed path]
    G --> H
    H --> I{prefixed key exists?}
    I -->|Yes| J[use prefixed value]
    I -->|No| K[keep legacy value and mark changed]
    J --> L[save merged values to prefixed path]
    K --> L

Loading

File-Level Changes

Change	Details	Files
Add legacy-cache fallback and prefixed-cache overlay behavior while preserving the existing save path.	Parameterize cache-directory resolution by an explicit path prefix. Load legacy storage first, then load prefixed storage so prefixed keys take precedence. Track keys loaded from each cache and mark the merged cache dirty when legacy-only keys need migration into the prefixed cache. Classify missing, valid, and malformed cache files separately, continuing past malformed legacy data but failing on malformed prefixed data.	src/dconfigfile.cpp include/global/dconfigfile.h
Extend metadata permission parsing for authorized access modes.	Add authorized read-only and authorized read-write permission enum values. Parse the corresponding metadata permission strings.	include/global/dconfigfile.h src/dconfigfile.cpp tests/ut_dconfigfile.cpp
Add regression coverage for cache overlay and permission behavior across cache scopes and path layouts.	Verify prefixed values override conflicting legacy values. Verify legacy-only user and global values are retained and persisted into the prefixed cache. Cover no-appid and nested-subpath cache paths. Validate authorized permission parsing.	tests/ut_dconfigfile.cpp
Update package metadata and source copyright information.	Adjust the source copyright year range. Include the additional Debian control changes.	debian/control include/global/dconfigfile.h

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="src/dconfigfile.cpp" line_range="393-394" />
<code_context>
+        if (tmp == QLatin1String("readwrite")) {
             p = DConfigFile::ReadWrite;
+        } else if (tmp == QLatin1String("authorizedreadonly")) {
+            p = DConfigFile::AuthorizedReadOnly;
+        } else if (tmp == QLatin1String("authorizedreadwrite")) {
+            p = DConfigFile::AuthorizedReadWrite;
+        }
</code_context>
<issue_to_address>
**🚨 issue (security):** Metadata entries with `permissions: "authorizedreadonly"` are parsed as `AuthorizedReadOnly`, but `cacheValue()` only rejects exactly `ReadOnly`; cached values therefore override the default for authorized-read-only settings just like writable settings. The public cache access path has no authorization check, so unauthorized callers can use the cache to override these settings.

**Triggers:** When a configuration item uses `authorizedreadonly` metadata and a cache contains a value for it.

**Suggested fix:** Handle `AuthorizedReadOnly` separately in `cacheValue()` and enforce the intended authorization policy before accepting a cached override.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

🚨 issue (security): Metadata entries with permissions: "authorizedreadonly" are parsed as AuthorizedReadOnly, but cacheValue() only rejects exactly ReadOnly; cached values therefore override the default for authorized-read-only settings just like writable settings. The public cache access path has no authorization check, so unauthorized callers can use the cache to override these settings.

Triggers: When a configuration item uses authorizedreadonly metadata and a cache contains a value for it.

Suggested fix: Handle AuthorizedReadOnly separately in cacheValue() and enforce the intended authorization policy before accepting a cached override.