Repository navigation
Conversation
1. Root cause: updateHighlighterAll() rehighlights every block synchronously without yielding, blocking UI thread for ~6s on medium files during print preview 2. Fix: call qApp->processEvents() every 100 blocks to keep UI responsive, consistent with cloneLargeDocument() pattern 3. Cleanup: remove dead DPrinter printer(QPrinter::HighResolution) in popupPrintDialog(), introduced by commit 9fcf3e4, which triggers unnecessary cups plugin load and printer enumeration 4. Impact: print preview opens faster, no behavior change for syntax highlighting or print output Log: 优化打印预览页面打开速度，减少 UI 阻塞 Influence: 1. Test print preview with medium/large syntax-highlighted files 2. Verify syntax highlighting renders correctly in print preview 3. Test print preview with plain text files (no highlighter) 4. Verify no -Wunused-variable warnings after dead code removal fix: 优化打印预览页面响应速度，减少 UI 线程阻塞 1. 根因：updateHighlighterAll() 同步遍历所有文本块执行语法高亮， 无 processEvents 间歇，中小文件打印预览时阻塞 UI 线程约 6 秒 2. 方案：循环中每 100 块调用 qApp->processEvents() 保持 UI 响应， 与 cloneLargeDocument() 现有模式一致 3. 清理：删除 popupPrintDialog() 中 DPrinter printer(QPrinter:: HighResolution) 死代码，由 commit 9fcf3e4 引入，会触发不必要的 cups 插件加载和打印机枚举 4. 影响：打印预览打开速度提升，语法高亮和打印输出行为不变 Log: 优化打印预览页面打开速度，减少 UI 阻塞 Influence: 1. 测试中等/大型语法高亮文件的打印预览 2. 验证打印预览中语法高亮渲染正确 3. 测试纯文本文件（无语法高亮）的打印预览 4. 验证删除死代码后无 -Wunused-variable 告警残留 PMS: BUG-375053
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideImproves print-preview responsiveness by periodically yielding during large syntax-highlighting passes and removes an unused printer object that triggered needless printer enumeration, without changing highlighting or print output behavior. Sequence diagram for responsive print preview highlightingsequenceDiagram
participant Window
participant Preview as DPrintPreviewDialog
participant Editor as EditWrapper
participant Highlighter as QSyntaxHighlighter
participant Qt as qApp
Window->>Preview: setAttribute
Preview->>Editor: updateHighlighterAll()
loop Each text block
Editor->>Highlighter: rehighlightBlock(var)
opt Every 100 blocks
Editor->>Qt: processEvents()
end
end
Editor->>Highlighter: rehighlightBlock(endBlock)
Preview-->>Window: responsive preview UI
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ❌评价： 存在逻辑缺陷 ❌ 不通过 潜在问题： 建议： ['在 processEvents() 调用后添加 m_bQuit 和 m_pSyntaxHighlighter 有效性检查，若无效则 return 退出循环', '使用 QPointer 守卫对象，processEvents() 后检查守卫是否仍然有效', '在 processEvents() 后重新验证 QTextBlock 迭代器 var 的有效性（var.isValid()），若失效则退出循环', '参考同代码库 cloneLargeDocument() 函数（约2255-2261行）的 QPointer + 取消标志模式'] 2. 代码质量 ✅评价： 代码结构清晰，注释完整 ✅ 通过 潜在问题： 建议： [] 3. 代码性能 ✅评价： 性能良好，资源使用合理 ✅ 通过 潜在问题： 建议： ['将魔法数字 100 提取为命名常量，如 static const int kProcessEventInterval = 100;'] 4. 代码安全 🔒评价： 存在0个安全漏洞 ✅ 通过
安全漏洞详情： 建议： [] 💡 改进建议代码示例// src/editor/editwrapper.cpp - updateHighlighterAll() 修复示例
// 参考 cloneLargeDocument() 的 QPointer + 取消标志模式
int blockCount = 0;
for (QTextBlock var = beginBlock; var != endBlock; var = var.next()) {
m_pSyntaxHighlighter->rehighlightBlock(var);
if (++blockCount % 100 == 0) {
qApp->processEvents();
// 检查退出标志和对象有效性
if (m_bQuit || !m_pSyntaxHighlighter) {
return;
}
// 重新验证迭代器有效性（文档可能已被修改）
if (!var.isValid()) {
return;
}
}
}本报告由 AI 代码审查工具自动生成 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: reduce print preview delay by yielding UI events
synchronously without yielding, blocking UI thread for ~6s on
medium files during print preview
responsive, consistent with cloneLargeDocument() pattern
in popupPrintDialog(), introduced by commit 9fcf3e4, which
triggers unnecessary cups plugin load and printer enumeration
syntax highlighting or print output
Log: 优化打印预览页面打开速度，减少 UI 阻塞
Influence:
fix: 优化打印预览页面响应速度，减少 UI 线程阻塞
无 processEvents 间歇，中小文件打印预览时阻塞 UI 线程约 6 秒
与 cloneLargeDocument() 现有模式一致
HighResolution) 死代码，由 commit 9fcf3e4 引入，会触发不必要的
cups 插件加载和打印机枚举
Log: 优化打印预览页面打开速度，减少 UI 阻塞
Influence:
PMS: BUG-375053
Summary by Sourcery
Improve print preview responsiveness without changing syntax highlighting or print output behavior.
Bug Fixes:
Enhancements: