[pengfeixx]

Summary

Fix two SIGSEGV crashes (exit 139) in the editor_core unit tests by stubbing EditWrapper::markdownRenderer() in the shared test fixture.

Problem

syncRendererFindHighlight() (introduced in d08b8fe, search-highlight sync for ReadView) is called at the end of highlightKeyword() / highlightKeywordInView() and does:

IMarkdownRenderer *renderer = m_wrapper->markdownRenderer();
if (!renderer) return;
...
renderer->highlightSearch(...);   // pure virtual

The editor_core fixture uses a fake EditWrapper (reinterpret_cast<EditWrapper *> over a QWidget carrier) and stubs many of its members — but not markdownRenderer(). The real inline getter therefore ran on the QWidget carrier, read a garbage non-null pointer from the m_pRenderer offset, and the subsequent virtual highlightSearch() call dereferenced it, crashing the process:

• test_dtextedit_cursor: TextEditTest.PrevLine_WithFindBarVisible_HighlightsSyncedKeyword (crash after Scan completed)
• test_dtextedit_find: TextEditTest.ReplaceNext_WithHighlightSelection_ReplacesOnce (crash after Rendering all selections completed)

Both binaries aborted mid-suite, so all subsequent test cases were lost and the CI job finished with exit code 139.

Changes

• tests/editor_core/editor_core_fixture.h: stub EditWrapper::markdownRenderer() to return nullptr in installWrapperSeams(), matching the real EditWrapper default (m_pRenderer = nullptr, early return in syncRendererFindHighlight). Existing assertions are unaffected: m_findMatchSelections etc. are populated before syncRendererFindHighlight() runs.

Testing

• Built with CMAKE_BUILD_TYPE=Debug -DBUILD_TESTS=ON
• test_dtextedit_cursor: 56/56 PASSED (previously exit 139)
• test_dtextedit_find: 57/57 PASSED (previously exit 139)
• Run under QT_QPA_PLATFORM=offscreen

Summary by Sourcery

Make the editor_core test fixture return no markdown renderer so search-highlight synchronization safely follows the production default.

Bug Fixes:

• Prevent editor_core unit-test crashes caused by the fake EditWrapper exposing an invalid markdown renderer pointer.
• Restore complete execution of the affected cursor and find test suites.

Tests:

• Verify the cursor and find test suites pass completely after the fixture fix.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The shared editor_core unit-test fixture now stubs EditWrapper::markdownRenderer() to return nullptr, preventing an invalid renderer pointer and virtual call when search-highlight synchronization runs; the affected cursor and find test suites complete successfully.

File-Level Changes

Change	Details	Files
Prevent editor_core fixture crashes by making the fake wrapper report no Markdown renderer.	Add the Markdown renderer interface dependency to the fixture. Stub markdownRenderer() to return nullptr alongside the existing wrapper seams. Allow syncRendererFindHighlight() to take its normal null-renderer early-return path while preserving existing selection assertions.	tests/editor_core/editor_core_fixture.h

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[deepin-ci-robot]

deepin pr auto review

🤖 AI 代码审查报告

总体评分： 100 分 (通过阈值: 70分)

---

📊 总体评价

项目	结果
审查结论	代码审查通过
评分详情	本次变更在单元测试 fixture 中为 EditWrapper::markdownRenderer 添加桩函数，修复了因 d08b8fe 引入的调用链导致的段错误。注释详尽，逻辑正确，与真实 EditWrapper 默认行为对齐，无安全漏洞，代码质量优秀。

---

🔍 详细分析

1. 语法逻辑 ✅

评价： 语法正确，逻辑清晰 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

---

2. 代码质量 ✅

评价： 代码结构清晰，注释完整 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

---

3. 代码性能 ✅

评价： 性能良好，资源使用合理 ✅ 通过

潜在问题：
✅ 未发现明显问题

建议： []

---

4. 代码安全 🔒

评价： 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情：
✅ 未发现安全漏洞

建议： []

---

💡 改进建议代码示例

# 当前代码已是正确实现，无需修改。桩函数返回 nullptr 对齐真实 EditWrapper 默认行为： stub.set_lamda(&EditWrapper::markdownRenderer,
               [](EditWrapper *) -> IMarkdownRenderer * { return nullptr; });

---

本报告由 AI 代码审查工具自动生成

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, pengfeixx

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pengfeixx]

/merge