Skip to content

sync: from linuxdeepin/dde-session-shell#519

Merged
mhduiy merged 1 commit into
masterfrom
sync-pr-73-nosync
Jul 9, 2026
Merged

sync: from linuxdeepin/dde-session-shell#519
mhduiy merged 1 commit into
masterfrom
sync-pr-73-nosync

Conversation

@deepin-ci-robot

@deepin-ci-robot deepin-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#73

Summary by Sourcery

Align licensing and compliance metadata with upstream for session shell components.

Documentation:

  • Add SPDX license headers to mfasequencecontrol source and header files.

Chores:

  • Replace REUSE.toml with a .reuse/dep5 configuration file to adjust REUSE licensing metadata.

@sourcery-ai

sourcery-ai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Syncs licensing metadata with upstream by adding SPDX headers to MFA sequence control sources and switching from REUSE.toml to a .reuse/dep5-based configuration.

File-Level Changes

Change Details Files
Add SPDX license and copyright headers to MFA sequence control implementation and header.
  • Insert SPDX-FileCopyrightText comment for UnionTech Software Technology Co., Ltd.
  • Specify GPL-3.0-or-later license via SPDX-License-Identifier in both implementation and header files
src/session-widgets/mfasequencecontrol.cpp
src/session-widgets/mfasequencecontrol.h
Switch REUSE licensing configuration from REUSE.toml to .reuse/dep5.
  • Remove existing REUSE.toml configuration file
  • Add new .reuse/dep5 configuration file for REUSE compliance
REUSE.toml
.reuse/dep5

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The SPDX-FileCopyrightText year is set to 2026 in the new headers; please double-check that this future date is intentional and aligns with the rest of the project’s licensing metadata.
  • Now that REUSE.toml has been removed in favor of .reuse/dep5, verify that the DEP5 configuration fully covers these files and is consistent with the existing REUSE setup in other parts of the repository.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The SPDX-FileCopyrightText year is set to 2026 in the new headers; please double-check that this future date is intentional and aligns with the rest of the project’s licensing metadata.
- Now that REUSE.toml has been removed in favor of .reuse/dep5, verify that the DEP5 configuration fully covers these files and is consistent with the existing REUSE setup in other parts of the repository.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#73
@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

deepin pr auto review

★ 总体评分:79分

■ 【总体评价】

代码实现了开源许可证合规性更新,但存在版权年份笔误
规范性良好但因年份错误导致语法和质量维度扣分

■ 【详细分析】

  • 1.语法逻辑(存在错误)✕

src/session-widgets/mfasequencecontrol.cppsrc/session-widgets/mfasequencecontrol.h 文件中,添加的版权声明年份为 2026,当前年份早于此年份,属于明显的输入错误。
潜在问题:版权年份逻辑错误导致声明信息与实际不符
建议:将 2026 修改为当前正确的年份,如 2024

  • 2.代码质量(一般)✕

代码遵循了 REUSE 规范,添加了 SPDX 头部和许可证文件,更新了 REUSE.toml 中的路径配置,这是良好的开源实践。但版权年份的笔误降低了整体代码质量,且配置文件更新缺乏详细注释说明。
潜在问题:版权信息不准确影响项目的合规性记录;配置项变更缺乏上下文说明
建议:仔细核对版权年份;在 REUSE.toml 中为新增路径添加简要注释说明其用途

  • 3.代码性能(无性能问题)✓

本次修改仅涉及文本文件、配置文件和注释的添加与更新,不涉及任何可执行代码逻辑或循环结构,对运行时性能无任何影响。
建议:无需修改

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改为许可证合规性更新,不涉及任何用户输入处理、内存操作或权限管理,不存在安全风险。
建议:无需修改

■ 【改进建议代码示例】

--- a/src/session-widgets/mfasequencecontrol.cpp
+++ b/src/session-widgets/mfasequencecontrol.cpp
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2026 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
--- a/src/session-widgets/mfasequencecontrol.h
+++ b/src/session-widgets/mfasequencecontrol.h
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2026 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later

@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MyLeeJiEun

Copy link
Copy Markdown

/merge

@deepin-bot

deepin-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

Permission denied

@mhduiy mhduiy merged commit 7c5bdd0 into master Jul 9, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants