ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#175
Merged
ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#175
Conversation
…s them [citest_skip] tox-lsr 3.17.1 has a fix for the broken container tests There was one shell function for both setting up the callback plugins and the connection plugin. When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not set, so all subsequent tests failed. The connection plugin must be present and the env. var. must be set in order to run any container tests. The code was fixed to ensure that there is always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS is always set and contains this path. Also, setting up the callback plugins and the connection plugin is already idempotent, so no reason to skip them. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates CI workflows to use tox-lsr 3.17.1 and adjusts container integration test settings so that required Ansible connection plugins are always configured, plus adds an explicit community.general collection dependency. Sequence diagram for container tests ensuring connection_plugin setup via tox_lsr_3_17_1sequenceDiagram
actor Developer
participant GithubActions as Github_Actions_Workflow
participant Pip as pip3
participant ToxLsr as tox_lsr_3_17_1
participant AnsibleTest as ansible_test_container
Developer->>GithubActions: Push_changes_trigger_workflow
GithubActions->>Pip: Install_tox_lsr_version_3_17_1
Pip-->>GithubActions: tox_lsr_3_17_1_installed
GithubActions->>ToxLsr: Run_container_test_environment_setup
ToxLsr->>ToxLsr: Install_connection_plugin_if_missing
ToxLsr->>ToxLsr: Set_ANSIBLE_CONNECTION_PLUGINS_env_var
ToxLsr-->>GithubActions: Environment_ready_for_container_tests
GithubActions->>AnsibleTest: Run_container_integration_tests
AnsibleTest->>AnsibleTest: Use_configured_connection_plugin
AnsibleTest-->>GithubActions: Report_test_results_to_workflow
GithubActions-->>Developer: CI_status_with_fixed_container_tests
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The tox-lsr version is hardcoded separately in multiple workflows; consider defining it once via a shared environment variable, composite action, or reusable workflow so future version bumps only require a single change.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The tox-lsr version is hardcoded separately in multiple workflows; consider defining it once via a shared environment variable, composite action, or reusable workflow so future version bumps only require a single change.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox-lsr 3.17.1 has a fix for the broken container tests
There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.
Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI configuration to use tox-lsr 3.17.1 and ensure container tests and dependencies run correctly.
Bug Fixes:
Enhancements:
CI: