Fix set max_rd_atomic respecting the local device limit#353
Fix set max_rd_atomic respecting the local device limit#353sfff wants to merge 1 commit intolinux-rdma:masterfrom
Conversation
When configuring max_rd_atomic account for our device's constraint in cases where the destination's max_qp_rd_atom (from ibv_devinfo -v) exceeds our local limit.
|
@sfff, Thanks for the PR. |
|
@sshaulnv, Thank you for the review and the improvement suggestion. I agree that the current approach may appear somewhat complex.
Would it make sense to rename I would like to additionally point out that this patch is intended to prevent an error in cases where the local value (printed in test header) is lower than the value obtained from the remote side. |
|
I would like to clarify why I think keeping the current output format unchanged is the least intrusive option for this fix. The header prints the local requested/configured test parameters. In contrast, the With this patch, the value programmed into Adding this value into the existing address line would mix two different meanings in one line: endpoint exchange data and negotiated QP configuration. It would also change an established compact output format that may already be consumed by scripts/parsers. For that reason, I would prefer to keep this patch limited to the functional fix and avoid changing the output format unless you strongly prefer an explicit additional line. @sshaulnv Does this explanation address your concern about the report output, or would you still prefer a follow-up output change before merge? |
When configuring max_rd_atomic account for our device's constraint in cases where the destination's max_qp_rd_atom (from ibv_devinfo -v) exceeds our local limit.