[spyre] Update the ulimit for the sentient group #37
+63
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahithiRavindranath
force-pushed
the
spyrenew
branch
4 times, most recently
from
93be22e to
5e6aded
Compare
If the currently set ulimit value is higher than the configured limit, it does not need to be reduced, as higher values are harmless. The validation parses the configuration and checks the memlimit value. If the currently set memlimit is greater than or equal to the configured value, the check passes; otherwise, it fails. Signed-off-by: Sahithi Ravindranath <Sahithi.Ravindranath@ibm.com>
multi-card spyre containers eventually runs out of locked memory and can cause the containers to exit. Updating the memlock config to the max value containers might consume based on the number of cards in the system would prevent the containers exiting due to locked memory exhaustion. Signed-off-by: Sahithi Ravindranath <Sahithi.Ravindranath@ibm.com>
sahithiRavindranath
force-pushed
the
spyrenew
branch
from
5e6aded to
3a6673c
Compare
| line_str = line_match.group(1) | ||
| line_value = line_match.group(2) | ||
| conf_str = conf_match.group(1) | ||
| if line_str == conf_str: |
Contributor
There was a problem hiding this comment.
Can you define a function push the above logic there? Add some documentation for that function.
| config_file) | ||
|
|
||
| status = True | ||
| pattern = r'^(.+?)\s+(unlimited|\d+)$' |
Contributor
There was a problem hiding this comment.
Please add an example that matches with above patter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multi-card spyre containers eventually runs out of locked memory and caused the conatiners to exit.
Updating the memlock config to the max value containers might consume based on the number of cards in the system