ocp: Fix core dump during telemetry log decode#3074
Open
jeff-lien-sndk wants to merge 1 commit intolinux-nvme:masterfrom
Open
ocp: Fix core dump during telemetry log decode#3074jeff-lien-sndk wants to merge 1 commit intolinux-nvme:masterfrom
jeff-lien-sndk wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
When decoding ocp 2.5 telemetry log with json output the internal-log ocp plugin command was hitting an issue that caused a core dump. This commit will resolve that error. Signed-off-by: jeff-lien-sndk <jeff.lien@sandisk.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When decoding ocp 2.5 telemetry log with json output the internal-log ocp plugin command was hitting an issue that caused a core dump. This commit will resolve that error.
Here's the actual error that this PR resolves:
nvme ocp internal-log /dev/nvme0n1 -f fifo_da_1-2_cctemp-telemetry.bin -s fifo_da_1-2_cctemp-string.bin --output-format json -t host -d 2
Missing telemetry-log. Fetching from drive...
telemetry.bin generated. Proceeding with next steps.
Extracting Telemetry Host Dump (Data Area 2)...
nvme: ./json_object.c:1490: json_object_array_add: Assertion `json_object_get_type(jso) == json_type_array' failed.
Aborted (core dumped)