Skip to content

Allow service to also disconnect at shutdown#3066

Open
dschwartz783 wants to merge 1 commit intolinux-nvme:masterfrom
dschwartz783:patch-1
Open

Allow service to also disconnect at shutdown#3066
dschwartz783 wants to merge 1 commit intolinux-nvme:masterfrom
dschwartz783:patch-1

Conversation

@dschwartz783
Copy link

Added to keep service running in background, so that nvme can be disconnected at shutdown.

Currently, at least on Ubuntu, a variety of services hang due to the nvme device files being tied to active connections, which no longer work once the network has been brought down. This fixes that. Connections will be terminated before passing network-online.target.

Added to keep service running in background, so that nvme can be disconnected at shutdown
@tbzatek
Copy link
Contributor

tbzatek commented Jan 19, 2026

Well this needs to exclude connections that provide the system itself, e.g. access to rootfs, /boot, /usr (if separate), /var etc. Including any connection done within initramfs. And not only that, for NBFT connections additional device paths may have been connected during the system runtime and the original device paths may get disconnected.

If the application strings / context would exclude such connections from disconnect-all, we'd need to consistently mark all such connections. Similar to excluding network interfaces being torn down if they provide access to rootfs connections.

@tbzatek
Copy link
Contributor

tbzatek commented Jan 19, 2026

See also #2913

@igaw
Copy link
Collaborator

igaw commented Jan 22, 2026

Indeed, there are dragons. The connection mapping to block device is not working at all. It is completely decoupled.

While the current configuration works for certain use cases, it might not work for others. Because it is hard to understand what this change will break I am very hesitant to touch it at the moment.

Furthermore, we don't have any CI tests which could help to figure out what it would break.

FWIW, I plan to work a bit on this but no guarantee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants