Allow service to also disconnect at shutdown#3066
Allow service to also disconnect at shutdown#3066dschwartz783 wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
Added to keep service running in background, so that nvme can be disconnected at shutdown
|
Well this needs to exclude connections that provide the system itself, e.g. access to rootfs, If the application strings / context would exclude such connections from |
|
See also #2913 |
|
Indeed, there are dragons. The connection mapping to block device is not working at all. It is completely decoupled. While the current configuration works for certain use cases, it might not work for others. Because it is hard to understand what this change will break I am very hesitant to touch it at the moment. Furthermore, we don't have any CI tests which could help to figure out what it would break. FWIW, I plan to work a bit on this but no guarantee. |
Added to keep service running in background, so that nvme can be disconnected at shutdown.
Currently, at least on Ubuntu, a variety of services hang due to the nvme device files being tied to active connections, which no longer work once the network has been brought down. This fixes that. Connections will be terminated before passing network-online.target.