nvme-print: introduce nvme_show_cmd_err() helper function#3065
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Jan 23, 2026
Merged
nvme-print: introduce nvme_show_cmd_err() helper function#3065igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
Contributor
Author
|
This is for the PR: #3056 closed without merging but seems difficult to add the feature to the |
igaw
reviewed
Jan 22, 2026
libnvme/src/nvme/ioctl.h
Outdated
| __u32 timeout_ms; | ||
| __u32 rsvd2; | ||
| __u64 result; | ||
| bool admin; |
Collaborator
There was a problem hiding this comment.
struct nvme_passthru_cmd should not be changed. It's a 1:1 mapping of Linux kernel one.
Unfortunately, my original brain farth to just look at the opcode doesn't work.
Collaborator
|
I would just introduce two versions
|
Contributor
Author
|
I see and will do consider to use them. Thank you. |
Add the cmd argument for nvme_show_err() to use nvme_show_opcode_status(). Do not change nvme_show_err() itself so add nvme_show_cmd_err() instead. Also add admin variable into the nvme_passthru_cmd structure. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
show-cmd-err
branch
from
1affcfa to
03d9db0
Compare
Contributor
Author
|
Just fixed the patch as mentioned. Thank you. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the cmd argument for nvme_show_err() to use nvme_show_opcode_status(). Do not change nvme_show_err() itself so add nvme_show_cmd_err() instead. Also add admin variable into the nvme_passthru_cmd structure.