TPT-3778: Add explicit GitHub Actions permissions#107
Open
zliang-akamai wants to merge 1 commit into
Open
Conversation
zliang-akamai
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the combined test/lint GitHub Actions workflow to explicitly declare least-privilege permissions, addressing the actions/missing-workflow-permissions code scanning finding by setting the workflow’s default GITHUB_TOKEN permission to contents: read.
Changes:
- Add an explicit top-level
permissionsblock to.github/workflows/tests.yaml. - Restrict workflow token permissions to
contents: read(sufficient foractions/checkoutin this workflow).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add explicit least-privilege
contents: readpermission to the combined test and lint workflow.This addresses code scanning alert 71 for
actions/missing-workflow-permissions. Code scanning alert 70 points to the historical.github/workflows/lint.yaml, which has already been removed frommain; a subsequent default-branch scan should close that stale finding.