feat: [UIE-10184] - IAM: add permissions to UI#13409
feat: [UIE-10184] - IAM: add permissions to UI#13409aaleksee-akamai merged 4 commits intolinode:developfrom
Conversation
|
|
||
| const userName = | ||
| (isProxyOrDelegateUserType ? parentProfile : profile)?.username ?? ''; | ||
| const userName = (isProxyUserType ? parentProfile : profile)?.username ?? ''; |
There was a problem hiding this comment.
we have a ticket for that UIE-10223, I've done it here in order to see that you've logged as a delegate user for testing purpose
However, I don't know why it was done for proxy users
Cloud Manager UI test results🔺 1 failing test on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/parentChild/account-switching.spec.ts" |
|||||||||||||||||
mpolotsk-akamai
left a comment
There was a problem hiding this comment.
Looks good to me. Tested parent/child with and without permissions. Everything works as expected. Thanks!
abailly-akamai
left a comment
There was a problem hiding this comment.
This looks great - thx @aaleksee-akamai
Although it's unlikely for this PR, due to the the recent regressions we encountered with the legacy experience we should triple down testing all cases.
@abailly-akamai , I think we need to merge your PR into develop (after the release) and check if it helps |
* feat: [UIE-10184] - IAM: add permissions to UI * typo * Added changeset: IAM Parent/Child: add permissions to UI
Description 📝
This PR disables/enables UI for default roles and account delegations based on permissions.
Note: Delegate users also will be able to add/remove the delegate roles
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅