feat: [UIE-10166] - IAM: url params for tables#13397
feat: [UIE-10166] - IAM: url params for tables#13397aaleksee-akamai merged 5 commits intolinode:developfrom
Conversation
…ned Entities tables
abailly-akamai
left a comment
There was a problem hiding this comment.
Changes look great in the UI and the behavior is solid - I tested with a bunch of combinations (search, filtering, pagination etc) and confirmed the feature enhancement. Nice one!
One quick thing (unrelated to this particular PR) that could potentially be a little confusing for a user is adding an unrelated role once a filter has been applied because the table will show no update, maybe thinking this was a no-op. I don't know if there is a good way to approach this other then resetting all filters/params when adding a new role but wanted to mention it anyway (I still think we have the right approach).
As far as the code cleanup, take it or leave it - since there is a lot of logic repeat we could:
- consolidate search param types in the route file (it was done like that for some other components)
- address some of the cleanups I commented on (and potentially abstract the logic in a util file)
again - nit stuff
packages/manager/src/features/IAM/Shared/AssignedEntitiesTable/AssignedEntitiesTable.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/IAM/Shared/AssignedEntitiesTable/AssignedEntitiesTable.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/IAM/Shared/AssignedEntitiesTable/AssignedEntitiesTable.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/IAM/Shared/AssignedRolesTable/AssignedRolesTable.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/IAM/Shared/AssignedRolesTable/AssignedRolesTable.tsx
Show resolved
Hide resolved
packages/manager/src/features/IAM/Shared/AssignedRolesTable/AssignedRolesTable.tsx
Show resolved
Hide resolved
mpolotsk-akamai
left a comment
There was a problem hiding this comment.
Tested the verification steps, everything works as expected. Thanks!
39c646f to
636c096
Compare
Cloud Manager UI test results🔺 1 failing test on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/account/quotas-storage.spec.ts" |
|||||||||||||||||
Description 📝
This PR adds the URL params to Assigned Roles and Assigned Entities tables
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-02-13.at.12.10.44.PM.mov
Screen.Recording.2026-02-13.at.12.08.39.PM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅