-
Notifications
You must be signed in to change notification settings - Fork 662
feat(cli): Update header docs link to be conditional for CI environments #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(cli): Update header docs link to be conditional for CI environments #1616
Conversation
|
Hey @adityasharmawork! Just checking in - are you still working on this PR? We noticed there are some comments that may need addressing. If you need more time, no problem! Just let us know. If we don't hear back within a week, we'll close this to keep the repo tidy, but you can always reopen when ready. |
|
@adityasharmawork your PR is missing a change set. Please add it. |
|
@sumitsaurabh927 Thank you sir for highlighting this to me, I have added it now! |
|
Hi @sumitsaurabh927 and @vrcprl ! I think all checks have passed, if it's okay, can it be merged to main? Once please have a look into this, do lemme know if any changes required! |
|
@adityasharmawork also – please enable commit signature in your account, and re-push the commits so they're signed - otherwise GitHub won't let us merge the PR due to the security settings. Thank you! https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
Summary
Updated the CLI header to display environment-aware documentation links based on the runtime environment (CI/CD vs Default).
Changes
isCIhelper function inpackages/cli/src/cli/utils/ui.tsto detect CI environments without external package dependencies.renderHerofunction to conditionally set the documentation link.https://lingo.dev/go/docsto dynamic paths:https://lingo.dev/ci(in CI) andhttps://lingo.dev/cli(default).Testing
Business logic tests added:
node bin/cli.mjs logindisplayshttps://lingo.dev/cliin the header by default.CI=true node bin/cli.mjs logindisplayshttps://lingo.dev/ciin the header.Visuals
Required for UI/UX changes:
CLI Mode -
CI Mode -
Checklist
Closes #1078