Skip to content

Add code signing + notarization to release workflow #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
axelniklasson wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add code signing + notarization to release workflow #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec1bf4c
Add code signing to release action
axelniklasson Mar 5, 2026
aed1782
Add comment
axelniklasson Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,41 @@ jobs:
--define "CLI_VERSION='$VERSION'" \
src/index.ts --outfile=./bin/linear-release

- name: Import code signing certificate
if: matrix.os == 'macos-latest'
env:
CSC_LINK: ${{ secrets.CSC_LINK }}
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
run: |
echo "$CSC_LINK" | base64 --decode > certificate.p12
security create-keychain -p "" build.keychain
security default-keychain -s build.keychain
security unlock-keychain -p "" build.keychain
security import certificate.p12 -k build.keychain -P "$CSC_KEY_PASSWORD" -T /usr/bin/codesign
security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "" build.keychain
rm certificate.p12

- name: Code sign macOS executable
if: matrix.os == 'macos-latest'
run: |
codesign --force --deep --sign - ./bin/linear-release || true
codesign --entitlements entitlements.mac.plist --force --options runtime \
--sign "Developer ID Application: Linear Orbit, Inc. (${{ secrets.APPLE_TEAM_ID }})" ./bin/linear-release
codesign --verify --verbose ./bin/linear-release

- name: Notarize macOS executable
if: matrix.os == 'macos-latest'
env:
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
run: |
ditto -c -k --keepParent ./bin/linear-release ./bin/linear-release.zip
xcrun notarytool submit ./bin/linear-release.zip \
--apple-id "$APPLE_ID" \
--team-id "$APPLE_TEAM_ID" \
--password "$APPLE_APP_SPECIFIC_PASSWORD" \
--wait
rm ./bin/linear-release.zip

- name: Upload artifact
uses: actions/upload-artifact@v4
Expand Down
17 changes: 17 additions & 0 deletions entitlements.mac.plist
View file
Open in desktop
Copy link
Member

@mufeez-amjad mufeez-amjad Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this is valid per Bun docs https://bun.sh/docs/guides/runtime/codesign-macos-executable?utm_source=openai

Copy link
Collaborator Author

@axelniklasson axelniklasson Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks a little scary at first but just went with what Bun recommends so should be fine.. Will add a link to the Bun docs too so it's explicit.

Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!-- https://bun.sh/docs/guides/runtime/codesign-macos-executable -->
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.security.cs.allow-jit</key>
<true/>
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
<true/>
<key>com.apple.security.cs.disable-executable-page-protection</key>
<true/>
<key>com.apple.security.cs.allow-dyld-environment-variables</key>
<true/>
<key>com.apple.security.cs.disable-library-validation</key>
<true/>
</dict>
</plist>