Skip to content

LINBEE-30104 | fix: hold edits until the verdict line is printed (v1.4.7) - #23

Open
nivSwisa1 wants to merge 4 commits into
mainfrom
LINBEE-30104-verdict-hold
Open

nivSwisa1 wants to merge 4 commits into
mainfrom
LINBEE-30104-verdict-hold

Conversation

@nivSwisa1

Copy link
Copy Markdown
Contributor

Source edits and subagent spawns are now held until the real verdict line is printed (max 3 holds per repo/session), so a prose grade or a file switch can't skip it; hook messages also name the SKILL.md as a fallback when the skill isn't listed.

🤖 Generated with Claude Code

…4.7)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 10:45

@orca-security-us orca-security-us Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed OSS Licenses high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Valid verdicts produced through the advertised SKILL.md fallback do not release the hold or reach reporting.

1 open issue
What changed in this PR

This PR updates agentic-advisor to v1.4.7, strengthening the verdict-before-work checks for source edits and subagent spawns.

Changes:

  • Repeats holds while a verdict is missing, with an intended limit of three per repo/session.
  • Adds SKILL.md fallback guidance and limits non-blocking reminders to read tools.
  • Updates regression tests, documentation, and release metadata.
File Description
tests/​agentic-advisor/​hooks_test.sh Tests repeated holds, file switching, prose grades, and fallback guidance.
plugins/​agentic-advisor/​README.md Documents repeated holds and read reminders.
plugins/​agentic-advisor/​hooks/​agentic-advisor-trigger.sh Adds the hold counter and SKILL.md fallback messages.
plugins/​agentic-advisor/​CHANGELOG.md Records the v1.4.7 behavior changes.
plugins/​agentic-advisor/​.claude-plugin/​plugin.json Bumps the version to 1.4.7.

Review effort: Balanced

Comment thread plugins/agentic-advisor/hooks/agentic-advisor-trigger.sh Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 10:52
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Fallback detection can bypass grading and misclassify telemetry, while reminder tracking and concurrent hold counting remain incorrect.

3 open issues
1 previously missed issue

In code that hasn't changed since last review

Medium severity Serialize hold counter updates to prevent concurrent overwrites

plugins/​agentic-advisor/​hooks/​agentic-advisor-trigger.sh:228

Concurrent Edit or Agent hooks can read the same hold count and overwrite each other's increments, allowing more than three denials per repo/session. Serialize the counter update with a per-repo/session lock and fail open if the lock cannot be acquired.

1 resolved since last review

Review effort: Balanced

Comment thread plugins/agentic-advisor/hooks/agentic-advisor-report.sh Outdated
Comment thread plugins/agentic-advisor/hooks/agentic-advisor-trigger.sh Outdated
Comment thread plugins/agentic-advisor/hooks/agentic-advisor-trigger.sh Outdated
Copilot AI balanced review requested due to automatic review settings October 26, 2026 10:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Verified fallback-detection failures on long transcripts can reapply holds, suppress telemetry, and misclassify baseline sessions.

1 open issue
3 resolved since last review

Review effort: Balanced

Comment thread plugins/agentic-advisor/hooks/agentic-advisor-trigger.sh Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 11:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Concurrent calls can exceed the hold cap, and fallback grading can reuse another repository’s verdict.

1 open issue
1 previously missed issue

In code that hasn't changed since last review

Medium severity Serialize hold-cap checks and increments

plugins/​agentic-advisor/​hooks/​agentic-advisor-trigger.sh:230

Parallel edits or subagent spawns can overwrite each other's counter increments: four overlapping calls can all be denied while recording only one hold. This exceeds the documented three-hold cap per repo/session. Serialize the check and increment with a per-marker lock that fails open on contention, and add coverage for concurrent calls.

1 resolved since last review

Review effort: Balanced

and ((.value.input.skill? // "") | tostring | contains($n))) | .key] as $calls
| [$c | to_entries[] | select(.value.type? == "tool_use" and .value.name? == "Read"
and ((.value.input.file_path? // "") | tostring | test("/skills/[^/]*" + $n + "[^/]*/SKILL\\.md$"))) | .key] as $reads
| (if ($calls | length) > 0 then $calls else $reads[0:1] end) as $sk

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants