fix(NO-TASK): Replace PSR2R namespace sniffs removed upstream - #42
Merged
Conversation
composer.json requires fig-r/psr2r-sniffer ^2.0.0, but the Linchpin ruleset
still referenced PSR2R.Namespaces.UnusedUseStatement and
PSR2R.Namespaces.UseInAlphabeticalOrder. psr2r 2.x deleted both in favour of
Slevomat's implementations, leaving NoInlineFullyQualifiedClassName as the only
sniff in that category.
phpcs treats an unresolvable rule ref as a hard error, so the whole standard
failed to load:
ERROR: Referenced sniff "PSR2R.Namespaces.UnusedUseStatement" does not exist
Consumers could not work around it either — phpcs resolves refs before applying
<exclude>, so excluding the dead sniffs in a project's phpcs.xml.dist still
aborts. Linchpin-Minimum never referenced them, which is why linchpin-blocks
was unaffected.
Swapped both to their Slevomat equivalents. slevomat/coding-standard is a hard
dependency of psr2r-sniffer 2.x, so it is always installed alongside it.
UnusedUses is configured with searchAnnotations so an import referenced only
from a @param/@return/@var docblock still counts as used — without it the sniff
tells you to delete imports that PHPStan then reports as unresolvable types.
Note for consumers: mantle's composer.json says 1.1.8 while its composer.lock
still pins v1.1.6 with psr2r 0.6.4, where the old sniffs exist. Its phpcs run
works today and breaks the moment that lock is refreshed, so this wants
releasing before any repo on the full Linchpin ruleset updates.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
composer.jsonrequiresfig-r/psr2r-sniffer: ^2.0.0, but theLinchpinruleset still referenced two sniffs that psr2r 2.x deleted:PSR2R.Namespaces.UnusedUseStatementPSR2R.Namespaces.UseInAlphabeticalOrderNamespaces.NoInlineFullyQualifiedClassNameis the only sniff left in that category upstream.phpcs treats an unresolvable rule
refas a hard error, not a warning, so the entire standard failed to load before running a single check:Consumers cannot work around this on their side either — phpcs resolves refs before applying
<exclude>, so excluding the dead sniffs in a project'sphpcs.xml.diststill aborts (it just prints the error twice).Linchpin-Minimumnever referenced them, which is why linchpin-blocks was unaffected.The fix
Swapped both to their Slevomat equivalents.
slevomat/coding-standardis a hard dependency offig-r/psr2r-sniffer2.x, so it is guaranteed present wherever the^2.0.0constraint resolves — no new dependency.UnusedUsesis configured withsearchAnnotations: true. Without it the sniff flags imports referenced only from@param/@return/@vardocblocks — which PHPStan then reports as unresolvable types. This was not theoretical: it fired on a real@return array<int,REST_Interface>while testing.Why this needs releasing promptly
mantle's
composer.jsonsays1.1.8while itscomposer.lockstill pins v1.1.6 with psr2r 0.6.4, where the old sniffs exist. Itscomposer phpcsworks today and breaks the moment that lock is refreshed. Same exposure for any repo on the fullLinchpinruleset.Verification
Confirmed against a real consumer (
linchpin/packagist-plugin-manager, which is adopting the standard in linchpin/packagist-plugin-manager#TBD): the ruleset now loads and runs, where before it aborted.The repo's own PHPUnit suite errors on
WordPressCS\WordPress\AbstractArrayAssignmentRestrictionsSniffnot found inSlowMetaQuerySniff— I verified this is pre-existing by stashing this change and re-running: identical failure. Unrelated to this PR, but worth a separate look.🤖 Generated with Claude Code