feat: add Amazon Linux 2023 KVM image template#4630
feat: add Amazon Linux 2023 KVM image template#4630bonifaido wants to merge 1 commit intolima-vm:masterfrom
Conversation
bonifaido
force-pushed
the
amazonlinux
branch
4 times, most recently
from
3d344b9 to
981c8c6
Compare
|
Duplicate of: |
| set -euo pipefail | ||
|
|
||
| sudo dnf install -y spal-release | ||
| sudo dnf install -y fuse-sshfs |
There was a problem hiding this comment.
bonifaido
force-pushed
the
amazonlinux
branch
from
981c8c6 to
32b757f
Compare
| # fuse-sshfs is not included in EL | ||
| extrapkgs="${extrapkgs} fuse-sshfs" | ||
| # Amazon Linux 2023 (AL2023) needs 'spal-release' to provide fuse-sshfs | ||
| if grep -q "Amazon Linux.*2023" /etc/system-release; then |
There was a problem hiding this comment.
Isn't this likely true for future Amazon Linux 20XX releases too?
There was a problem hiding this comment.
Should be a symlink to amazonlinux-2023.yaml.
See other templates.
There was a problem hiding this comment.
Should be a symlink to amazonlinux-2023.yaml.
See other templates.
There was a problem hiding this comment.
templates/README.md has to be updated too
There was a problem hiding this comment.
If you took this code from #4454 (@electricalgorithm), show their credit in the commit message
There was a problem hiding this comment.
tbh I wasn’t aware of that PR, the script was made in that manner
bonifaido
force-pushed
the
amazonlinux
branch
from
32b757f to
5f0584a
Compare
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
bonifaido
force-pushed
the
amazonlinux
branch
from
5f0584a to
bc8a25b
Compare
|
I believe SPAL should not be enabled by default. Do we need to use the fusefs backend? |
|
my current issue is that after moving out the provision part from the yaml file the mounts stopped working, I’m looking into that |
|
Okay, I just checked out the other PR and it has some work there regarding the virtiofs based mounting as well, and in these terms it looks more advanced than this one. Happy to help out there (no need to have two competing PRs for the same feature). I have random issues with virtiofs, sometimes it works, sometimes it not, I found reverese-sshfs quite stable for amazonlinux and it served my needs well, thus I added the provision script that way. But I will possibly close this PR if the other one gets back to life. |
|
Let me close this PR, in favor of #4454 Thank you anyway for heading this up |
3 participants
This pull request introduces a new
amazonlinux.yamltemplate for configuringAmazon Linux 2023 (AL2023)virtual machines with Lima. I managed to boot Amazon Linux only with reverese-sshfs, but since sshfs is hidden in the SPAL repo of Amazon Linux we need a provision script at boot time to get it installed.