Fix breadcrumbs part filename typo + align template-part consistency (LS-1227)#9
Conversation
…dd missing post-content
- Rename parts/breadbrumbs.html to parts/breadcrumbs.html (typo fix)
- Align templates/page.html header/footer template-part blocks to the
fuller {slug,theme,area} form used in front-page.html/index.html
- Add missing wp:post-content block to templates/page.html and
templates/single.html — both were rendering header/footer only,
silently dropping all Page/Post content
Refs LS-1227
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughWordPress page and single templates now render theme-scoped header and footer parts around constrained post title and content blocks. The breadcrumbs template also loads the ChangesBlock template rendering
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Tick the box to add this pull request to the merge queue (same as
|
There was a problem hiding this comment.
Code Review
This pull request updates the templates/page.html and templates/single.html templates by wrapping the post title and content in a main group block and adding theme and area attributes to the header and footer template parts. The feedback suggests improving semantic HTML by explicitly setting the heading level to 1 on the wp:post-title block in both templates, and adding a wp:post-date block to the single post template to display the publication date.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Brandon Marshall <Brandonmarshall101@gmail.com>
…om/lightspeedwp/ls-theme into feature/template-part-housekeeping
ZaredRogers
left a comment
There was a problem hiding this comment.
Looks good @brandonmarshal
Summary
parts/breadbrumbs.htmltoparts/breadcrumbs.html(fixes a filename typo); content preserved as-is. Confirmed zero remaining references tobreadbrumbsanywhere in the repo.templates/page.html's header/footerwp:template-partblocks to the fuller{"slug":...,"theme":"ls-theme","area":...}form already used intemplates/front-page.htmlandtemplates/index.html, for consistency.templates/page.htmlandtemplates/single.htmlhad nowp:post-titleorwp:post-contentblocks at all — only header + footer template-parts. Any Page or Post content (and its title) was silently not rendered on the front end. Added both blocks, wrapped in amaingroup, matching the layout pattern already used infront-page.html/index.html.Out of scope (confirmed, not touched)
patterns/breadcrumbs.php,patterns/header.php, navigation-related code.develop, unrelated to this change. Actual breadcrumb wiring is tracked separately in LS-1228.Test plan
parts/breadcrumbs.htmlexists with original content;parts/breadbrumbs.htmlno longer existsbreadbrumbs(case-insensitive) — zero remaining referencestemplates/page.htmlheader/footer blocks matchfront-page.html/index.htmlexactlyparts/breadcrumbs.html,templates/page.html,templates/single.htmlLinear: LS-1227
Summary by CodeRabbit