Skip to content

Fix breadcrumbs part filename typo + align template-part consistency (LS-1227)#9

Merged
brandonmarshal merged 5 commits into
developfrom
feature/template-part-housekeeping
Jul 13, 2026
Merged

Fix breadcrumbs part filename typo + align template-part consistency (LS-1227)#9
brandonmarshal merged 5 commits into
developfrom
feature/template-part-housekeeping

Conversation

@brandonmarshal

@brandonmarshal brandonmarshal commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Renames parts/breadbrumbs.html to parts/breadcrumbs.html (fixes a filename typo); content preserved as-is. Confirmed zero remaining references to breadbrumbs anywhere in the repo.
  • Aligns templates/page.html's header/footer wp:template-part blocks to the fuller {"slug":...,"theme":"ls-theme","area":...} form already used in templates/front-page.html and templates/index.html, for consistency.
  • Follow-up fix discovered while manually verifying this change on a local WP install: templates/page.html and templates/single.html had no wp:post-title or wp:post-content blocks at all — only header + footer template-parts. Any Page or Post content (and its title) was silently not rendered on the front end. Added both blocks, wrapped in a main group, matching the layout pattern already used in front-page.html/index.html.

Out of scope (confirmed, not touched)

  • patterns/breadcrumbs.php, patterns/header.php, navigation-related code.
  • No template currently inserts the breadcrumbs part/pattern automatically anywhere in the theme — confirmed this is pre-existing behaviour on develop, unrelated to this change. Actual breadcrumb wiring is tracked separately in LS-1228.

Test plan

  • Confirmed parts/breadcrumbs.html exists with original content; parts/breadbrumbs.html no longer exists
  • Grepped full repo for breadbrumbs (case-insensitive) — zero remaining references
  • Verified templates/page.html header/footer blocks match front-page.html/index.html exactly
  • Manually tested on local WP install: created a Page with content, confirmed header → title → content → footer render correctly on the front end
  • Manually tested on local WP install: viewed an existing Post ("Hello world!"), confirmed header → title → content → footer render correctly on the front end
  • Confirmed Front Page and Index templates render unchanged (not touched by this PR)
  • No other files modified outside parts/breadcrumbs.html, templates/page.html, templates/single.html

Linear: LS-1227

Summary by CodeRabbit

  • New Features
    • Added breadcrumb pattern support for consistent navigation.
    • Updated page and post templates with structured header, main content, and footer sections.
    • Improved content layout with constrained presentation for titles and body content.

…dd missing post-content

- Rename parts/breadbrumbs.html to parts/breadcrumbs.html (typo fix)
- Align templates/page.html header/footer template-part blocks to the
  fuller {slug,theme,area} form used in front-page.html/index.html
- Add missing wp:post-content block to templates/page.html and
  templates/single.html — both were rendering header/footer only,
  silently dropping all Page/Post content

Refs LS-1227
@brandonmarshal brandonmarshal added area:theme Theme & styles (templates, template parts, FSE) comp:block-templates Template files/editor comp:template-parts Header/footer/loop/nav parts release:patch Backwards‑compatible bug fixes requiring a PATCH version bump (e.g., small fixes, docs updates). status:needs-review Awaiting code review labels Jul 13, 2026
@brandonmarshal brandonmarshal self-assigned this Jul 13, 2026
@linear-code

linear-code Bot commented Jul 13, 2026

Copy link
Copy Markdown

LS-1227

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@brandonmarshal, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d087a16f-733d-4f97-8977-e5fc0af41038

📥 Commits

Reviewing files that changed from the base of the PR and between f5a5125 and 9c117c0.

📒 Files selected for processing (2)
  • templates/page.html
  • templates/single.html
📝 Walkthrough

Walkthrough

WordPress page and single templates now render theme-scoped header and footer parts around constrained post title and content blocks. The breadcrumbs template also loads the ls-theme/breadcrumbs block pattern.

Changes

Block template rendering

Layer / File(s) Summary
Page and single template layout
templates/page.html, templates/single.html
Header and footer parts now specify the ls-theme theme and target areas, while constrained groups render post titles and content.
Breadcrumb pattern inclusion
parts/breadcrumbs.html
The breadcrumbs template loads the ls-theme/breadcrumbs WordPress block pattern.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main changes: fixing the breadcrumbs filename typo and aligning template-part usage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/template-part-housekeeping

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Jul 13, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the templates/page.html and templates/single.html templates by wrapping the post title and content in a main group block and adding theme and area attributes to the header and footer template parts. The feedback suggests improving semantic HTML by explicitly setting the heading level to 1 on the wp:post-title block in both templates, and adding a wp:post-date block to the single post template to display the publication date.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread templates/page.html Outdated
Comment thread templates/single.html Outdated
brandonmarshal and others added 3 commits July 13, 2026 14:50
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Brandon Marshall  <Brandonmarshall101@gmail.com>

@ZaredRogers ZaredRogers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @brandonmarshal

@brandonmarshal
brandonmarshal merged commit 1353d7b into develop Jul 13, 2026
5 of 7 checks passed
@brandonmarshal
brandonmarshal deleted the feature/template-part-housekeeping branch July 13, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:theme Theme & styles (templates, template parts, FSE) comp:block-templates Template files/editor comp:template-parts Header/footer/loop/nav parts release:patch Backwards‑compatible bug fixes requiring a PATCH version bump (e.g., small fixes, docs updates). status:needs-review Awaiting code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants