Add remaining missing icons sourced from Phosphor for the lightspeed collection - #24
Merged
krugazul merged 2 commits intoSep 9, 2026
Merged
Conversation
Icons Added - notepad.svg - clipboard-text.svg - github.svg - rocket-launch.svg - buildings.svg Source - Pulled from phosphor-icons/core assets/regular, byte-matched against the embedded SVGs already used in ls-theme's skipped icon-block instances - fill="currentColor" placed on <path>, matching the sanitizer-safe convention documented in assets/icons/lightspeed/README.md Context - Closes the remaining gap in LS-3229's "Missing icons" tracking list - Auto-registered by LS_Plugin\Icons on init — no PHP changes needed
brandonmarshal
added
area:block-editor
Context - Documents the 5 new lightspeed icons added in PR #24
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to new SVG assets that match the existing collection conventions, plus a straightforward changelog entry.
Pull request overview
This PR completes the lightspeed SVG icon collection by adding the remaining five missing Phosphor-sourced icons, enabling the outstanding ls-theme icon-block instances to migrate to core/icon without missing lightspeed/* mappings.
Changes:
- Added five new SVGs to
assets/icons/lightspeed/, following the collection’s single-pathfill="currentColor"convention. - Updated the Unreleased changelog to record the new icons and the LS-3229 tracking closure.
File summaries
| File | Description |
|---|---|
| CHANGELOG.md | Adds an Unreleased entry documenting the five new lightspeed icons and the LS-3229 closure. |
| assets/icons/lightspeed/rocket-launch.svg | New Phosphor-sourced icon (sanitiser-compatible fill="currentColor" on <path>). |
| assets/icons/lightspeed/notepad.svg | New Phosphor-sourced icon (sanitiser-compatible fill="currentColor" on <path>). |
| assets/icons/lightspeed/github.svg | New Phosphor-sourced icon (sanitiser-compatible fill="currentColor" on <path>). |
| assets/icons/lightspeed/clipboard-text.svg | New Phosphor-sourced icon (sanitiser-compatible fill="currentColor" on <path>). |
| assets/icons/lightspeed/buildings.svg | New Phosphor-sourced icon (sanitiser-compatible fill="currentColor" on <path>). |
Review details
- Files reviewed: 1/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
krugazul
approved these changes
Sep 9, 2026
krugazul
deleted the
feature/ls-3229-source-remaining-lightspeed-icons
branch
September 9, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the 5 icons still missing from the
lightspeedicon collection after #21, closing out the remainder of LS-3229's "Missing icons" cross-batch tracking list — the last icon-block instances acrossls-themethat couldn't be converted tocore/iconyet because no matchinglightspeed/*icon existed.New icons
notepad.svg— used by the homepage "Commercial" card (homepage-where-to-start.php)clipboard-text.svg— used by the homepage "Process" card (homepage-where-to-start.php)github.svg— used by the footer social-icon row (footer.php)rocket-launch.svg— used by the services feature card (section-card-services.php)buildings.svg— used by the consultation thank-you page (thank-you-consultation.php)All 5 are sourced from
phosphor-icons/core'sassets/regularset and verified byte-for-byte against the SVG paths already embedded in the correspondingls-themeicon-block instances (or, forrocket-launch/buildings, the plugin's own bundled icon name, which maps 1:1 to the same Phosphor identifier). Each file follows this collection's existing convention:viewBox="0 0 256 256",fill="currentColor"on<path>(not the<svg>root), matchingassets/icons/lightspeed/README.md.No PHP changes —
LS_Plugin\Iconsauto-registers every.svgdropped intoassets/icons/lightspeed/oninit.Test plan
npm run plugin:validate— passesnpm run security:scan— no new issues introduced by this branch (2 pre-existing warnings intaxonomy-filter/render.php, unrelated to this change)xmllint --noouton all 5 new SVG files — valid XML<path d="...">verified byte-for-byte against Phosphor'sassets/regularsource and/or the existing embedded SVG it replacesls-themepicks these upTracked under LS-3229.