Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix duplicate property names in an object literal, locate both occurrences and either remove one, or merge their configurations into a single property that encodes the desired behavior. For ESLint rule configs, that usually means keeping a single entry for each rule key, with the desired severity and options.
In this case, CodeQL flags
"import/no-anonymous-default-export": "warn"at line 154 because another"import/no-anonymous-default-export"property exists later in the samerulesobject and overwrites it. To fix the issue without changing intended functionality, we should keep only the rule configuration that is actually meant to be used. Since the later property is the one JavaScript uses at runtime, and we are not shown any differing options, the safest minimal change is to remove this earlier duplicate"import/no-anonymous-default-export": "warn"entry, leaving the later one intact. This preserves current ESLint behavior while removing the confusing overwritten property.Concretely: in
packages/eslint-config/react-lib.js, inside the exported configuration object’srulessection near lines 151–156, delete the line defining"import/no-anonymous-default-export": "warn",and leave the surrounding rules unchanged.