Skip to content

[kyb] add issuing_authority to document#483

Merged
gcamata merged 1 commit into
mainfrom
05-19-_kyb_add_issuing_authority_to_document
May 20, 2026
Merged

[kyb] add issuing_authority to document#483
gcamata merged 1 commit into
mainfrom
05-19-_kyb_add_issuing_authority_to_document

Conversation

@gcamata
Copy link
Copy Markdown
Contributor

@gcamata gcamata commented May 20, 2026

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment May 20, 2026 12:31am

Request Review

Copy link
Copy Markdown
Contributor Author

gcamata commented May 20, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

feat(api): add issuing_authority parameter to documents methods

csharp

feat(api): add issuing_authority field to documents models

go

feat(api): add issuingAuthority field to document operations

kotlin

feat(api): add issuingAuthority field to documents resource

openapi

feat(api): add issuingAuthority field to document upload

php

feat(api): add issuingAuthority field to documents upload/replace

python

feat(api): add issuing_authority to documents upload/replace methods

ruby

feat(api): add issuing_authority field to document models and params

typescript

feat(api): add issuingAuthority parameter and field to documents
⚠️ grid-openapi studio · code

Your SDK build had at least one warning diagnostic.
generate ✅

⚠️ grid-ruby studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ⚠️build ✅lint ❗test ✅

⚠️ grid-python studio · code

Your SDK build had at least one warning diagnostic.
generate ✅build ✅lint ✅test ✅

pip install https://pkg.stainless.com/s/grid-python/9b8e9da30438974cb17828510c702242833158ae/grid-0.0.1-py3-none-any.whl
⚠️ grid-kotlin studio · code

Your SDK build had at least one warning diagnostic.
generate ✅build ✅lint ✅test ✅

⚠️ grid-go studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ❗build ✅lint ❗test ❗

go get github.com/stainless-sdks/grid-go@dec3c04ac4adb64a71baff4fdf8e756b2166f8ed
⚠️ grid-typescript studio · code

Your SDK build had a failure in the build CI job, which is a regression from the base state.
generate ✅build ❗lint ❗test ❗

⚠️ grid-csharp studio · code

Your SDK build had a failure in the build CI job, which is a regression from the base state.
generate ❗build ❗lint ❗test ❗

⚠️ grid-php studio · code

Your SDK build had at least one "error" diagnostic.
generate ❗lint ✅test ✅

⚠️ grid-cli studio · code

Your SDK build had a failure in the build CI job, which is a regression from the base state.
generate ⚠️build ❗lint ❗test ❗


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-05-20 00:43:00 UTC

@gcamata gcamata marked this pull request as ready for review May 20, 2026 00:31
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 20, 2026

Greptile Summary

This PR adds an optional issuingAuthority string field to both the Document response schema and the BaseDocumentRequest request schema, representing the government agency or organization that issued the document (e.g., "U.S. Department of State").

  • The source schemas in openapi/components/schemas/documents/ are correctly edited, and both generated bundles (openapi.yaml and mintlify/openapi.yaml) reflect the bundled output from make build.
  • The new field is optional (not added to the required list) and placed consistently after documentNumber in both schemas, with matching descriptions and examples.

Confidence Score: 5/5

Safe to merge — additive-only, optional field added to both the request and response schemas with no breaking changes.

The change is a straightforward, non-breaking addition of a single optional string field. Both source schemas and their generated bundles are in sync. The field is correctly omitted from required in both schemas, and descriptions and examples are consistent between BaseDocumentRequest and Document.

No files require special attention.

Important Files Changed

Filename Overview
openapi/components/schemas/documents/Document.yaml Adds optional issuingAuthority field after documentNumber; correctly left out of required list.
openapi/components/schemas/documents/BaseDocumentRequest.yaml Adds optional issuingAuthority field with matching description and example as Document.yaml.
openapi.yaml Generated bundle updated with issuingAuthority in both BaseDocumentRequest and Document inline schemas — consistent with source changes.
mintlify/openapi.yaml Mintlify-specific generated bundle updated identically to root openapi.yaml.

Entity Relationship Diagram

%%{init: {'theme': 'neutral'}}%%
erDiagram
    BaseDocumentRequest {
        string file "binary, required"
        string documentType "required ($ref)"
        string side "optional (FRONT|BACK)"
        string country "required (ISO 3166-1 alpha-2)"
        string documentNumber "optional"
        string issuingAuthority "optional (NEW)"
    }

    Document {
        string id "required"
        string documentHolder "required"
        string documentType "required ($ref)"
        string side "optional (FRONT|BACK)"
        string country "required (ISO 3166-1 alpha-2)"
        string documentNumber "optional"
        string issuingAuthority "optional (NEW)"
        string fileName "required"
        datetime createdAt "required"
        datetime updatedAt "optional"
    }

    BaseDocumentRequest ||--o{ Document : "submitted as / returned as"
Loading

Reviews (1): Last reviewed commit: "[kyb] add issuing_authority to document" | Re-trigger Greptile

@gcamata gcamata merged commit ee7013f into main May 20, 2026
8 of 9 checks passed
@gcamata gcamata deleted the 05-19-_kyb_add_issuing_authority_to_document branch May 20, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants