add buildkit-setup composite action#6
Draft
markatto wants to merge 1 commit into
Draft
Conversation
Wires up docker/setup-buildx-action with driver=remote pointed at the shared buildkitd in the tooling-prod EKS cluster (lightsparkdev/tooling-infra PRs #30 + lightsparkdev/ops#2727 set up the cluster side). Workflow authors get a one-line replacement for the standard setup-buildx-action call: - uses: lightsparkdev/.github/actions/buildkit-setup@v1 - uses: docker/build-push-action@v6 The runner pod has the mTLS client cert mounted at /etc/buildkit-client/ already (gha-runner-scale-set chart in tooling-infra), so the action doesn't need any secrets or auth plumbing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
lightsparkdev/.github/actions/buildkit-setup— a composite action that wiresdocker/setup-buildx-actionagainst the shared rootless buildkitd in thetooling-prodEKS cluster.Workflow author shape goes from this:
to this, with no other diff:
The composite action handles
driver: remote, the buildkitd Service endpoint, and the mTLS material (/etc/buildkit-client/{ca.crt,tls.crt,tls.key}, mounted into every ARC runner pod bycharts/arc-runner/values.yamlin tooling-infra). Authors don't see any of the auth or transport plumbing.Depends on
Both should land before users start using this action.
Tagging
After merge, tag as
v1(or use a movingv1ref via the standard GH actions release flow) so workflows can pin@v1.Test plan
lightsparkdev/tooling-infra/.github/workflows/builds + pushes a hello-world image via this action against anarc-runner-Nrunner.lightsparkdev/golinks/.github/workflows/ci.yml— small, standalone). Verifydocker/build-push-actionsucceeds and the layer cache survives a second build.