fix: make all typecheck and test gates green on macOS - #292
Open
VanniMnemonic wants to merge 3 commits into
Open
fix: make all typecheck and test gates green on macOS#292VanniMnemonic wants to merge 3 commits into
VanniMnemonic wants to merge 3 commits into
Conversation
tsc (node/web/root/builtins), eslint, build, test:node and test:py all pass now. - Enable rewriteRelativeImportExtensions: node:test runs the TS suites with native type stripping, which requires .ts import specifiers. - Include src/shared/types in tsconfig.node.json and drop the orphaned collections.ts that pulled the renderer store into the node graph. - Type readdir entries as Dirent[] and annotate the assetLibraryUi map callbacks so the null-filter predicates check against declared types. - Fix the macOS registration bug in generator_registry: abspath does not resolve /var to /private/var, so authorized extensions stayed blocked as "incomplete installation". Compare against ext_dir.resolve() instead. - Prefer api/.venv in run-pytests.mjs: the system Python lacks fastapi.
Drop unconditional stdout prints that fired at import time and on every registry init/reload; WARNING and ERROR diagnostics are kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rewriteRelativeImportExtensions(node:test needs.tsspecifiers for native type-stripping), includesrc/shared/typesin the node project, drop the orphanedcollections.ts, typeDirent[]entries, annotateassetLibraryUimap callbacks, add a null guard in the UI test.generator_registry:os.path.abspathdoes not resolve/var→/private/var, so correctly-authorized extensions stayed blocked as "incomplete installation". Now compares againstext_dir.resolve().run-pytests.mjspreferapi/.venv(system Python lacks fastapi) and bump Electron to^44.1.1(pending from the packaging work).Test plan
npx tsc --noEmitgreen on all four projects (node, web, root, builtins) — 26 errors → 0npm run test:node— 118/118 passnpm run test:py— 63/63 pass (was 2 import errors + 2 failures)npx eslint .— cleannpm run build— exit 0