-
Notifications
You must be signed in to change notification settings - Fork 124
liquidity: scriptable autoloop #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
d92eba4
317bea4
c5a63c1
e4edd6e
b62e81b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -128,6 +128,18 @@ type Parameters struct { | |||||||||
| // swaps. If set to true, the deadline is set to immediate publication. | ||||||||||
| // If set to false, the deadline is set to 30 minutes. | ||||||||||
| FastSwapPublication bool | ||||||||||
|
|
||||||||||
| // ScriptableAutoloop enables Starlark-based scriptable autoloop mode. | ||||||||||
| // This mode is mutually exclusive with EasyAutoloop and threshold rules. | ||||||||||
|
Comment on lines
+132
to
+133
|
||||||||||
| ScriptableAutoloop bool | ||||||||||
|
|
||||||||||
| // ScriptableScript is the Starlark script to evaluate on each tick. | ||||||||||
| // Required when ScriptableAutoloop is true. | ||||||||||
|
Comment on lines
+136
to
+137
|
||||||||||
| // ScriptableScript is the Starlark script to evaluate on each tick. | |
| // Required when ScriptableAutoloop is true. | |
| // ScriptableScript is the Starlark script source to evaluate on each tick, | |
| // and is required when ScriptableAutoloop is true. |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ScriptableTickInterval parameter is defined and passed through RPC but is never actually used in the implementation. The scriptableAutoLoop function doesn't use a custom ticker based on this interval - it just uses the same ticker as other autoloop modes. Either implement the custom tick interval functionality by creating a separate ticker when ScriptableTickInterval is set, or remove this unused parameter from the API to avoid misleading users.
| // ScriptableTickInterval overrides the default tick interval for | |
| // scriptable mode. Zero means use DefaultAutoloopTicker. | |
| ScriptableTickInterval time.Duration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flag name 'scriptautoloop' is inconsistent with the naming pattern used elsewhere in the codebase and the PR. Throughout the protobuf definitions, Go structs, and documentation, the feature is called 'scriptable_autoloop' (with 'able'). The CLI flag should be '--scriptableautoloop' to match this convention and make the feature name consistent across the entire codebase.