Skip to content

Conversation

@tankyleo
Copy link
Contributor

Also document the automatic creation of the database if it does not exist.

Also document the automatic creation of the database if it does not
exist.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 23, 2026

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo tankyleo requested a review from tnull January 23, 2026 06:13
@tankyleo
Copy link
Contributor Author

Fixes #77

@tankyleo tankyleo self-assigned this Jan 23, 2026

- Install Rust and Cargo (https://www.rust-lang.org/tools/install).
- Install PostgreSQL 15 (https://www.postgresql.org/download/)
- Install openssl (used for TLS connections to the postgres backend: https://docs.rs/openssl/latest/openssl/#automatic)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Install openssl (used for TLS connections to the postgres backend: https://docs.rs/openssl/latest/openssl/#automatic)
- Install OpenSSL (used for TLS connections to the PostgreSQL backend: https://docs.rs/openssl/latest/openssl/#automatic)

environment variables as needed. Add PostgreSQL endpoint configuration.
2. Create table in PostgreSQL using `./impls/src/postgres/sql/`
environment variables as needed.
2. VSS will setup a Postgres database on first launch if it is not found. You can also manually create the database
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. VSS will setup a Postgres database on first launch if it is not found. You can also manually create the database
2. VSS will setup a PostgreSQL database on first launch if it is not found. You can also manually create the database

without authentication for local testing or in trusted setups. The VSS-rust-client supports LNURL-auth & JWT based
authentication and authorization. Switching to simple HTTP header authentication is straightforward by adding another
implementation. Note that the security of authentication heavily relies on using HTTPS for all requests.
* **Authentication and Authorization**: Currently, the VSS-server supports authentication via Proof-of-Knowledge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proof-of-Knowledge of what? Two-three more words might help here. Also maybe link to the new section below?

authentication and authorization. Switching to simple HTTP header authentication is straightforward by adding another
implementation. Note that the security of authentication heavily relies on using HTTPS for all requests.
* **Authentication and Authorization**: Currently, the VSS-server supports authentication via Proof-of-Knowledge
or [JWT](https://datatracker.ietf.org/doc/html/rfc7519). The API also offers hooks for simple HTTP header
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
or [JWT](https://datatracker.ietf.org/doc/html/rfc7519). The API also offers hooks for simple HTTP header
or [JWT](https://datatracker.ietf.org/doc/html/rfc7519). The API also offers hooks for simple HTTP header-based

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we describe these rust-only changes in the global README, maybe we should consider to remove the java version soonish? What's our current thinking around timeline for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants