Skip to content

Re-enable signer op for one channel at a time in chanmon_consistency#4489

Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
wpaulino:re-enable-single-channel-signer
Mar 17, 2026
Merged

Re-enable signer op for one channel at a time in chanmon_consistency#4489
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
wpaulino:re-enable-single-channel-signer

Conversation

@wpaulino
Copy link
Contributor

Node B has two channels: one with A and another with C. Re-enabling signer ops only one channel at a time allows us to have them in different states, which may be helpful for fuzzing coverage.

Requested at #4411 (comment).

Node B has two channels: one with A and another with C. Re-enabling
signer ops only one channel at a time allows us to have them in
different states, which may be helpful for fuzzing coverage.
@wpaulino wpaulino requested a review from TheBlueMatt March 17, 2026 17:54
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Mar 17, 2026

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-claude-review-bot
Copy link
Collaborator

The split of node B's signer opcodes into per-channel variants correctly filters signer_unblocked, but enable_op_for_all_signers still enables the signer op globally for both of node B's channels. This means the two channels never actually have different signer states — only different notification states. See inline comment for details.

@TheBlueMatt TheBlueMatt merged commit fd08d54 into lightningdevkit:main Mar 17, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants