Skip to content

Remove TaprootChannelSigner and musig2 crate#4481

Open
wpaulino wants to merge 3 commits intolightningdevkit:mainfrom
wpaulino:remove-taproot
Open

Remove TaprootChannelSigner and musig2 crate#4481
wpaulino wants to merge 3 commits intolightningdevkit:mainfrom
wpaulino:remove-taproot

Conversation

@wpaulino
Copy link
Contributor

@wpaulino wpaulino commented Mar 12, 2026

No description provided.

wpaulino added 3 commits March 12, 2026 13:00
@wpaulino
Remove TaprootChannelSigner
747788b 
We plan to have a single channel signer type going forward, so this is
unnecessary.
@wpaulino
Remove musig2 crate
85aa95b 
Taproot support is not planned we see an increase in demand for it by
users. The `musig2` crate is now owned by a third-party, and ultimately
won't be used by the production version of Taproot that we end up
releasing.
@wpaulino
Remove ChannelSignerType
961b451 
We plan to have a single channel signer type going forward, so this is
unnecessary.
@wpaulino wpaulino requested a review from tankyleo March 12, 2026 20:06
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Mar 12, 2026 •
edited
Loading

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 90.47619% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.98%. Comparing base (647c3f7) to head (961b451).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 90.27% 12 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4481      +/-   ##
==========================================
- Coverage   85.98%   85.98%   -0.01%     
==========================================
  Files         159      158       -1     
  Lines      105415   105397      -18     
  Branches   105415   105397      -18     
==========================================
- Hits        90643    90624      -19     
- Misses      12255    12258       +3     
+ Partials     2517     2515       -2
Flag Coverage Δ
tests 85.98% <90.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Mar 16, 2026

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tankyleo tankyleo Awaiting requested review from tankyleo

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wpaulino @ldk-reviews-bot