Conversation
|
👋 I see @valentinewallace was un-assigned. |
|
🔔 1st Reminder Hey @valentinewallace! This PR has been waiting for your review. |
lightning/src/ln/channelmanager.rs
Outdated
| let logger = WithChannelContext::from(&self.logger, &chan.context(), None); | ||
| match chan.peer_connected_get_handshake(self.chain_hash, &&logger) { | ||
| ReconnectionMsg::Reestablish(msg) => { | ||
| log_debug!(logger, "Generating channel_reestablish events"); |
There was a problem hiding this comment.
log is wrong now, now we'd already generated the event, and now we're writing this per-channel, which is fine but merits a string update.
elnosh
force-pushed
the
move-chanreestablish
branch
from
a3ba402 to
daff171
Compare
| let logger = WithChannelContext::from(&self.logger, &chan.context(), None); | ||
| match chan.peer_connected_get_handshake(self.chain_hash, &&logger) { | ||
| ReconnectionMsg::Reestablish(msg) => { | ||
| log_debug!( |
There was a problem hiding this comment.
Ironically this is actually our only place we log at DEBUG (or higher) when a peer connects, can we add variants of this in the other branches (including None, I think, if we have a Channel entry for a peer makes sense to log).
There was a problem hiding this comment.
(including
None, I think, if we have aChannelentry for a peer makes sense to log).
I wasn't sure when this would happen, seems only when the signer hasn't provided a point so I just added a generic peer reconnection msg.
elnosh
force-pushed
the
move-chanreestablish
branch
from
daff171 to
cfde1ca
Compare
|
No issues found. The |
4 participants
extremely small thing but unless I'm missing something, this doesn't need to be logged all the time. Just noticed it while seeing connections with peers with no channels.