Skip to content

Conversation

@tnull
Copy link
Contributor

@tnull tnull commented Jan 23, 2026

In the last few days there was incompatibility of cargo-semver-checks with the new stable Rust 1.93.0. While this should fixed by today's release of cargo-semver-checks, we take the opportunity to drop an unnecessary install step from the CI workflow, as the action will bring their own Rust version if not configured otherwise.

In the last few days there was incompatibility of `cargo-semver-checks`
with the new stable Rust 1.93.0. While this should fixed by today's
release of `cargo-semver-checks`, we take the opportunity to drop an
unnecessary install step from the CI workflow, as the action will bring
their own Rust version if not configured otherwise.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 23, 2026

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.79%. Comparing base (8cdc86a) to head (5da7499).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4339      +/-   ##
==========================================
+ Coverage   86.53%   86.79%   +0.25%     
==========================================
  Files         158      158              
  Lines      103190   102788     -402     
  Branches   103190   102788     -402     
==========================================
- Hits        89300    89212      -88     
+ Misses      11469    11229     -240     
+ Partials     2421     2347      -74     
Flag Coverage Δ
fuzzing 36.20% <ø> (-0.86%) ⬇️
tests 86.08% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird thing for them to do tbh, but okay.

@TheBlueMatt TheBlueMatt merged commit feef6a4 into lightningdevkit:main Jan 23, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants