Remove low-hanging fruit rustfmt::skips in Channel #3854
Remove low-hanging fruit rustfmt::skips in Channel #3854tnull merged 2 commits intolightningdevkit:mainfrom
rustfmt::skips in Channel #3854Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3854 +/- ##
==========================================
- Coverage 89.94% 89.91% -0.03%
==========================================
Files 163 163
Lines 131655 131753 +98
Branches 131655 131753 +98
==========================================
+ Hits 118421 118472 +51
- Misses 10550 10590 +40
- Partials 2684 2691 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
valentinewallace
dismissed
joostjager’s stale review
The merge-base changed after approval.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
rustfmt::skips were added recently all over channel.rs in order for formatting to be enforced for all new code added to the file. Here we remove a bunch of those skips that aren't necessary because the methods that are skipped are so short. Does not include cfg(splicing) code. Here we just remove the rustfmt skips, in the next commit we'll clean up the code that rustfmt made too vertical.
In the previous commit we formatted a bunch of short methods. Here we clean up the default formatting that rustfmt applied by extracting code into variables.
valentinewallace
force-pushed
the
2025-05-chan-fmt-followup
branch
from
1b96fd1 to
c356070
Compare
|
Rebased |
|
Ugh, this formatted a handful of lines that #3741 was about to rewrite. |
|
Heh, was hoping mine would land first, but all good. Rebase wasn't too bad. |
6 participants
Based on #3809, in the same spirit as #3844 and #3850