Move accept_channel checks into ChannelContext::do_accept_channel_checks#3123
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Jun 17, 2024
Merged
Conversation
4 tasks
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3123 +/- ##
==========================================
- Coverage 89.90% 89.90% -0.01%
==========================================
Files 121 121
Lines 99170 99181 +11
Branches 99170 99181 +11
==========================================
+ Hits 89159 89164 +5
+ Misses 7408 7407 -1
- Partials 2603 2610 +7 ☔ View full report in Codecov by Sentry. |
tnull
reviewed
Jun 13, 2024
| } | ||
| } | ||
|
|
||
| pub fn do_accept_channel_checks( |
Contributor
There was a problem hiding this comment.
Seems all the other pub methods here have doc comments. Should this, too?
TheBlueMatt
previously approved these changes
Jun 13, 2024
Collaborator
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Could use a doc comment like @tnull suggested, otherwise LGTM.
dunxen
force-pushed
the
2024-06-channelrefactor
branch
from
7857d24 to
e3fcbb6
Compare
…ecks` This is done ahead of getting the dual-funding implementation to reduce refactoring noise there.
dunxen
force-pushed
the
2024-06-channelrefactor
branch
from
e3fcbb6 to
0881b24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done ahead of getting the dual-funding implementation to reduce refactoring noise there.
See #2302.