Return payment hash & secret in Bolt11 and offer id in Bolt12 receive responses#163
Merged
valentinewallace merged 2 commits intolightningdevkit:mainfrom Mar 20, 2026
Merged
Conversation
|
I've assigned @valentinewallace as a reviewer! |
Before you would create an invoice and then need to decode it to get the payment hash/secret to then match it to a PaymentReceived event. Now we'll include those in the Bolt11ReceiveResponse to make it easier.
Same motivation as the bolt11 change, allow us to track bolt 12 receives without having to decode the offer.
benthecarman
force-pushed
the
bolt11-recv-ret
branch
from
c1ee8cf to
1a5ce9e
Compare
valentinewallace
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before you would create an invoice and then need to decode it to get the payment hash/secret to then match it to a
PaymentReceivedevent. Now we'll include those in the Bolt11ReceiveResponse to make it easier. Does the same for bolt 12 and the offer id