Skip to content

Conversation

@benthecarman
Copy link
Collaborator

This basically fills out the remaining ldk-node functions that were not used by the RPC/CLI.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 22, 2026

I've assigned @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@joostjager
Copy link
Contributor

joostjager commented Jan 22, 2026

One general question that I had for ldk-server is whether we want some light e2e testing? cli->client->server path.

Perhaps an LdkNode trait is a possibility to mock ldk-node and focus testing on ldk-server.

@benthecarman
Copy link
Collaborator Author

One general question that I had for ldk-server is whether we want some light e2e testing? cli->client->server path.

Yeah that would be nice, probably better for a separate PR though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants