Skip to content

Expose full payment retry strategy via Config#829

Open
benthecarman wants to merge 1 commit intolightningdevkit:mainfrom
benthecarman:config-retry-timeout
Open

Expose full payment retry strategy via Config#829
benthecarman wants to merge 1 commit intolightningdevkit:mainfrom
benthecarman:config-retry-timeout

Conversation

@benthecarman
Copy link
Contributor

@benthecarman benthecarman commented Mar 16, 2026

Replace the payment_retry_timeout_secs field with a PaymentRetryStrategyenum that mirrors LDK's Retry type, allowing users to choose between timeout-based and attempt-count-based retry strategies. Defaults to a 10-second timeout to preserve existing behavior.

This was something I needed when getting ldk-server working with loop.

@benthecarman benthecarman requested review from tankyleo and tnull March 16, 2026 17:36
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Mar 16, 2026

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative would be to expose the Retry completely to allow for attempts based version as well. However, the timeout is generally simpler and more in line with what people expect.

If we do it, I'd lean towards exposing retry_strategy: Retry in the config. Should be even pretty easy to handle in bindings, as uniffi should now expose tuple enum variants.

Replace the `payment_retry_timeout_secs` field with a `PaymentRetryStrategy`
enum that mirrors LDK's `Retry` type, allowing users to choose between
timeout-based and attempt-count-based retry strategies. Defaults to a
10-second timeout to preserve existing behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@benthecarman benthecarman force-pushed the config-retry-timeout branch from 5af55c9 to 4ddeb92 Compare March 17, 2026 16:59
@benthecarman
Copy link
Contributor Author

If we do it, I'd lean towards exposing retry_strategy: Retry in the config. Should be even pretty easy to handle in bindings, as uniffi should now expose tuple enum variants.

done

@benthecarman benthecarman changed the title Make payment retry timeout configurable via Config Expose full payment retry strategy via Config Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants