Expose full payment retry strategy via Config#829
Expose full payment retry strategy via Config#829benthecarman wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
tnull
left a comment
There was a problem hiding this comment.
An alternative would be to expose the
Retrycompletely to allow for attempts based version as well. However, the timeout is generally simpler and more in line with what people expect.
If we do it, I'd lean towards exposing retry_strategy: Retry in the config. Should be even pretty easy to handle in bindings, as uniffi should now expose tuple enum variants.
Replace the `payment_retry_timeout_secs` field with a `PaymentRetryStrategy` enum that mirrors LDK's `Retry` type, allowing users to choose between timeout-based and attempt-count-based retry strategies. Defaults to a 10-second timeout to preserve existing behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5af55c9 to
4ddeb92
Compare
done |
Replace the
payment_retry_timeout_secsfield with aPaymentRetryStrategyenum that mirrors LDK'sRetrytype, allowing users to choose between timeout-based and attempt-count-based retry strategies. Defaults to a 10-second timeout to preserve existing behavior.This was something I needed when getting ldk-server working with loop.