docs(skill): keep hub invite grants outside agent transcripts - #4517
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe documentation now treats ChangesHub invitation guidance
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to This documentation-only change keeps pairing grants out of agent transcripts without changing CLI behavior, so no merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. This pull request has been marked Ready for Review. |
리뷰 · 우선순위 65 / 80설명 바뀌는 곳은 세 파일입니다. tip 방향(보안·운영 실수 줄이기, hub/원격)과 잘 맞습니다. 기술 강제(에이전트가 명령을 아예 못 돌리게 막는 것)는 없고 가이드만이라, 에이전트가 무시하면 그대로 새어 나갈 수 있습니다. 본문도 그걸 인정합니다. 초안(draft)이고, 체크리스트에 로컬 전체 CI·Codex/CodeRabbit 해결이 비어 있습니다. 스킬 테스트·surface/structure/privacy는 통과했다고 합니다.
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
|
Thanks for checking the operator handoff. The requested one-line command is already present in the published head a6b1e93: recipe 10 says, “Have the operator run Validation update: the exact-head Cross-platform CI run 34760729556 failed only in the Windows 3/6 test teardown when removal of an isolated auth-context temporary directory returned EPERM. The same focused test passes locally on that head. A single rerun of the failed jobs is in progress; I am not marking full CI green yet. The branch is also beyond the latest-dev tolerance, so it remains Draft rather than invalidating the current run with an immediate rebase. |
a6b1e93 to
4f62d29
Compare
4f62d29 to
3a45afe
Compare
Summary
The operating skill tells an agent to execute
ocx hub invite --jsonand relay the generated command, even though the output contains a one-time pairing grant. Update the entrypoint, invite recipe and remote-hub reference to hand that secret-returning step to an operator terminal and keep both the grant and generated command out of chat.The agent still performs non-secret setup and verification, using expiry and bound browser origin for confirmation. This is guidance only: it does not change CLI behavior or introduce a technical enforcement boundary.
Verification
bun test tests/ci-workflows/skill-ocx.test.ts: 16 pass, 0 fail, 227 assertions.bun run skill:surface:check,bun run structure:check,bun run privacy:scan, andgit diff --check: passed.quick_validate.py: passed with UTF-8 input mode.src/cli/hub.tsand manually checked all three changed pages. No live pairing grant was minted.Checklist
Review readiness evidence
Rebased onto
devat15fbd49f3and pushed. Published head is3a45afe6a.Local verification on that head:
bun run typecheck,bun run structure:check,bun run privacy:scanandgit diff --checkall pass. This branch changes no source or test files; the diff is documentation underskills/ocx/, so the repository gates above are the applicable local checks.The earlier head
a6b1e93bcompleted hosted cross-platform CI green, 26 of 26 jobs, in run 34760729556 attempt 2. This head carries the same documentation content rebased onto newerdev, with a redundant self-referentialCo-authored-bytrailer removed from the commit message; the tree is otherwise unchanged.Hosted cross-platform CI has not been re-dispatched on this head. On current
devthewindowsshard fails independently of this pull request intests/clients/desktop-app-restart-posix.test.ts, adevregression fixed separately in #4564. That failure is not attributable to a documentation-only change.Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit